9.0: FEATURE: Put initiating user id and creation date into event metadata #3875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwaidelich
commented
Sep 1, 2022
skurfuerst
reviewed
Sep 1, 2022
...ntentRepository.Core/Classes/Feature/ContentStreamCreation/Event/ContentStreamWasCreated.php
Show resolved
Hide resolved
bwaidelich
changed the title
|
FYI: I plan to adjust the remaining code and tests later today |
Also remove "initiatingUserId" from command definitions and adjust tests
bwaidelich
commented
Sep 9, 2022
Makes the `UserIdProvider` a concept of the core package so that the user id can be determined "lazily". In practice this means that we can use the CR instance for _reading_ already before the authenticated user can be determined. When handling commands, an exception will be thrown if no user can be determined at this point. This also adjusts the event decoration in `\Neos\ContentRepository\Core\ContentRepository::handle()` such that `initiatingUserId` and `initiatingTimestamp` is not overridden once it is set (see #3887)
bwaidelich
changed the title
…ring A follow up to 5f80a56 adjusting further Behat tests to the Identifier -> Id refactoring
…ifier-id-refactoring 9.0: BUGFIX: Adjust remaining Behat tests to Identifier -> Id refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #3874