Skip to content

Conversation

fannheyward
Copy link
Member

Related #5416

@fannheyward fannheyward requested a review from Copilot August 27, 2025 01:22
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the table checking logic in the highlight_ranges function by adding a type check to ensure the opts parameter is a table before proceeding with its usage.

  • Replaces simple null check with combined null and type validation for the opts parameter
  • Ensures opts is always a valid table before accessing its properties

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

codecov bot commented Aug 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.99%. Comparing base (1807db6) to head (efb1e6b).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5417   +/-   ##
=======================================
  Coverage   97.99%   97.99%           
=======================================
  Files         280      280           
  Lines       27862    27862           
  Branches     5768     5768           
=======================================
  Hits        27302    27302           
  Misses        102      102           
  Partials      458      458           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fannheyward fannheyward merged commit 0205987 into master Aug 27, 2025
4 checks passed
@fannheyward fannheyward deleted the fix/highlight-range-table branch August 27, 2025 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant