Skip to content

Conversation

fannheyward
Copy link
Member

@fannheyward fannheyward commented Aug 26, 2025

There may be multiple changes applied, the cursor could be put in wrong place while fetching textEdit.

@fannheyward fannheyward requested a review from Copilot August 26, 2025 10:46
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue in the snippet session where the getTextEdit function was being called with incorrect parameters. The fix removes the unnecessary cursor and events.insertMode parameters from the function call.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

codecov bot commented Aug 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.98%. Comparing base (1807db6) to head (8e321d6).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5414      +/-   ##
==========================================
- Coverage   97.99%   97.98%   -0.01%     
==========================================
  Files         280      280              
  Lines       27862    27862              
  Branches     5768     5768              
==========================================
- Hits        27302    27301       -1     
+ Misses        102      100       -2     
- Partials      458      461       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fannheyward fannheyward changed the title fix(snippets): getTextEdit without cursor fix(snippets): getTextEdit without cursor position Aug 26, 2025
@fannheyward fannheyward force-pushed the fix/snippet-session-edit branch from 4901f75 to 1f319bf Compare August 26, 2025 10:55
@fannheyward fannheyward force-pushed the fix/snippet-session-edit branch from 1f319bf to de239a0 Compare August 27, 2025 01:44
@fannheyward fannheyward force-pushed the fix/snippet-session-edit branch from de239a0 to 8e321d6 Compare August 27, 2025 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant