More conventional config builder method names #543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lutovich
force-pushed
the
1.7-builder-methods
branch
from
1359968 to
8d28b87
Compare
Added static factory method `ConfigBuilder Config#builder()` and instance method `Config ConfigBuilder#build()`. They have same behaviour as existing `ConfigBuilder Config#build()` and `Config ConfigBuilder#toConfig()` but have more conventional names. Existing methods not deprecated to avoid all existing user code be marked as deprecated. New methods also consistent with `TransactionConfig`. Updated the codebase to use new methods.
lutovich
force-pushed
the
1.7-builder-methods
branch
from
8d28b87 to
82aa06d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added static factory method
ConfigBuilder Config#builder()and instance methodConfig ConfigBuilder#build(). They have same behaviour as existingConfigBuilder Config#build()andConfig ConfigBuilder#toConfig()but have more conventional names. Existing methods not deprecated to avoid all existing user code be marked as deprecated. New methods also consistent withTransactionConfig. Updated the codebase to use new methods.