Include database connection ID in debug logs #531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lutovich
force-pushed
the
1.7-connection-id
branch
3 times, most recently
from
3b0291a to
6b7677d
Compare
zhenlineo
approved these changes
Sep 27, 2018
driver/src/main/java/org/neo4j/driver/internal/logging/ChannelActivityLogger.java
Outdated
Show resolved
Hide resolved
Database's connection ID is returned in Bolt V3 as part of HELLO message response. This commit makes driver extract the supplied ID and include it in all debug log messages. This makes it possible to trace events on the same connection between driver and database.
Make messages include short channel id. Only creation and acquisition messages now include network addresses.
lutovich
force-pushed
the
1.7-connection-id
branch
from
6b7677d to
688abf0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Database's connection ID is returned in Bolt V3 as part of HELLO message response. This PR makes driver extract the supplied ID and include it in all debug log messages. This makes it possible to trace events on the same connection between driver and database.
Example of debug log:
Here driver channel ID is
0x77076520and database connection ID isbolt-42.