Skip to content

feat(tfo): update config naming #1699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2025
Merged

feat(tfo): update config naming #1699

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions driver/src/main/java/org/neo4j/driver/Config.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,13 +165,13 @@ public final class Config implements Serializable {

/**
* Defines whether the driver should try using TCP Fast Open if the runtime supports it. This option is ignored
* when the conditions described in {@link ConfigBuilder#withTcpFastOpenEnabled(boolean)} are not met.
* when the conditions described in {@link ConfigBuilder#withTryTcpFastOpen(boolean)} are not met.
* <p>
* <b>This option is experimental.</b>
* @since 6.0.0
*/
@Experimental
private final boolean tcpFastOpenEnabled;
private final boolean tryTcpFastOpen;

private Config(ConfigBuilder builder) {
this.logging = builder.logging;
Expand All @@ -195,7 +195,7 @@ private Config(ConfigBuilder builder) {
this.eventLoopThreads = builder.eventLoopThreads;
this.telemetryDisabled = builder.telemetryDisabled;
this.observationProvider = builder.observationProvider;
this.tcpFastOpenEnabled = builder.tcpFastOpenEnabled;
this.tryTcpFastOpen = builder.tryTcpFastOpen;
}

/**
Expand Down Expand Up @@ -418,7 +418,7 @@ public Optional<ObservationProvider> observationProvider() {

/**
* Returns whether the driver should try using TCP Fast Open if the runtime supports it. This option is ignored
* when the conditions described in {@link ConfigBuilder#withTcpFastOpenEnabled(boolean)} are not met.
* when the conditions described in {@link ConfigBuilder#withTryTcpFastOpen(boolean)} are not met.
* <p>
* <b>This option is experimental.</b>
* <p>
Expand All @@ -428,8 +428,8 @@ public Optional<ObservationProvider> observationProvider() {
* @since 6.0.0
*/
@Experimental
public boolean isTcpFastOpenEnabled() {
return tcpFastOpenEnabled;
public boolean isTryTcpFastOpen() {
return tryTcpFastOpen;
}

/**
Expand All @@ -454,7 +454,7 @@ public static final class ConfigBuilder {
private long fetchSize = 1000;
private int eventLoopThreads = 0;
private ObservationProvider observationProvider;
private boolean tcpFastOpenEnabled;
private boolean tryTcpFastOpen;

@SuppressWarnings("deprecation")
private NotificationConfig notificationConfig = NotificationConfig.defaultConfig();
Expand Down Expand Up @@ -950,8 +950,8 @@ public ConfigBuilder withTelemetryDisabled(boolean telemetryDisabled) {
* @since 6.0.0
*/
@Experimental
public ConfigBuilder withTcpFastOpenEnabled(boolean enabled) {
this.tcpFastOpenEnabled = enabled;
public ConfigBuilder withTryTcpFastOpen(boolean enabled) {
this.tryTcpFastOpen = enabled;
return this;
}

Expand Down
2 changes: 1 addition & 1 deletion driver/src/main/java/org/neo4j/driver/internal/DriverFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,7 @@ private BoltConnectionProvider createBoltConnectionProvider(
if (localAddress != null) {
additionalConfig.put("localAddress", localAddress);
}
additionalConfig.put("enableFastOpen", config.isTcpFastOpenEnabled());
additionalConfig.put("enableFastOpen", config.isTryTcpFastOpen());
return boltConnectionProviderFactory.create(
loggingProvider, BoltValueFactory.getInstance(), observationProvider, additionalConfig);
}
Expand Down