Introduce new Reactive Streams session #1325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
injectives
force-pushed
the
feature/reactor-session
branch
8 times, most recently
from
0ca83f8 to
9194cf9
Compare
This update introduces support for reactive session with Reactive Streams types. While it is similar to the deprecated `RxSession`, it includes the improvements introduced with the `ReactiveSession` that uses Flow API types. Sample session creation: ``` var session = driver.reactiveSession(org.neo4j.driver.reactivestreams.ReactiveSession.class); ```
injectives
force-pushed
the
feature/reactor-session
branch
from
9194cf9 to
d686822
Compare
michael-simons
approved these changes
Oct 26, 2022
There was a problem hiding this comment.
I want this. Good stuff.
Now think to just cut down the .session() methods to two (untyped gives you imperative, typed gives you whatever you want). Less is more.
For reference: neo4j-contrib/neo4j-http@6d47ae3
As we have discussed, I explored updating the session methods and will submit a separate PR for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update introduces support for reactive session with Reactive Streams types. While it is similar to the deprecated
RxSession, it includes the improvements introduced with theReactiveSessionthat uses Flow API types.Sample session creation: