Skip to content

Remove ServerInfo.Version #638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 7, 2022
Merged

Remove ServerInfo.Version #638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 0 additions & 14 deletions Neo4j.Driver/Neo4j.Driver/Internal/Result/SummaryBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,20 +115,6 @@ public void Update(BoltProtocolVersion boltVersion, string agent)

public string Address { get; }

public string Version
{
get
{
Console.Error.WriteLine("Warning: ServerInfo.Version is depricated from driver version 4.3 onwards and will be removed in 5.0. " +
"Please use ServerInfo.ProtocolVersion and ServerInfo.Agent instead.");
return Agent;
}
set
{
Agent = value;
}
}

public override string ToString()
{
return $"{GetType().Name}{{{nameof(Address)}={Address}, " +
Expand Down
11 changes: 0 additions & 11 deletions Neo4j.Driver/Neo4j.Driver/Summary/IServerInfo.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,16 +35,5 @@ public interface IServerInfo
/// Get the entire server agent string
/// </summary>
string Agent { get; }

/// <summary>
/// Get the version of Neo4j running at the server.
/// </summary>
/// <remarks>
/// Introduced since Neo4j 3.1. Default to <c>null</c> if not supported by server
/// Deprecated since Neo4j 4.3.
/// Will be removed in Neo4j 5.0.
/// Please use IServerInfo.Agent, IServerInfo.ProtocolVersion or call the dbms.components procedure instead.
/// </remarks>
string Version { get; }
}
}