Skip to content

Conversation

DanielBerton
Copy link

We created some examples and described the available statements, let me know if it's enough or is better add other documentation or examples

@jexp
Copy link
Member

jexp commented May 4, 2017

Cool, some notes.

  1. Overview shouldn't include the file, that should be in index.adoc
  2. Overview is only for a general listing, which will be replaced by just including the generated documentation csvs.
  3. this seems to be mixed with the refactoring examples ? (which are also in overview.adoc, and be moved out). I don't mind if you leave them in a single PR but please move it to a separate adoc file and include that in the right place in index.adoc

Thanks

@DanielBerton
Copy link
Author

@jexp ok we move the include in the index.adoc, we can put it in a separate section (like before Appendix: Complete Overview that contains all the overview.adoc) or inside an existing one?
The refactoring examples was merged #399 we can fix it in this PR or in a new issue.

@DanielBerton
Copy link
Author

I thought about modifying the refactor example in the issue #331 today

@DanielBerton
Copy link
Author

@jexp PR updated

@jexp
Copy link
Member

jexp commented May 5, 2017

Cool, thanks a lot !

@jexp jexp merged commit d366661 into neo4j-contrib:3.1 May 5, 2017
albertodelazzari pushed a commit to albertodelazzari/neo4j-apoc-procedures that referenced this pull request Jun 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants