Skip to content

Conversation

@Wi1l-B0t
Copy link
Contributor

@Wi1l-B0t Wi1l-B0t commented Nov 8, 2025

Description

A minor optimization: avoid data copy for Keccak256(ReadOnlySpan<byte>), Keccak256(Span<byte>)

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Unit Testing
  • Run Application
  • Local Computer Tests
  • No Testing

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Jim8y Jim8y added Waiting for Review Port-to-3.x Feature or PR must be ported to Neo 3.x branch and removed Ready to Merge labels Nov 8, 2025
@shargon shargon merged commit 9ff5dee into neo-project:master Nov 9, 2025
7 checks passed
@Wi1l-B0t Wi1l-B0t deleted the fix.avoid-datacopy-in-Keccak256 branch November 9, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Port-to-3.x Feature or PR must be ported to Neo 3.x branch Ready to Merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants