[N4] Init Treasury #4271

shargon · 2025-11-04T13:10:22Z

Description

Part of the N4 changes, this is focus in the treasury content, no more changes wanted like reward this contract.

Allow Nep17 payment.
Allow Nep11 payment.
Verified by the committee.

Type of change

Optimization (the change is only an optimization)
Style (the change is only a code style for better maintenance or standard purpose)
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

UT_NativeContract

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules

erikzhang · 2025-11-04T13:47:23Z

What is the purpose of this native contract?

shargon · 2025-11-04T13:57:09Z

What is the purpose of this native contract?

2.4 Neo4 roadmap said:

GAS Treasury Allocation:
A portion of newly generated GAS is allocated to the Treasury.

So we will need a treasury contract, isn't it?

vncoelho

I think it looks like to be a good idea.

erikzhang · 2025-11-04T14:14:44Z

OK, it's a good idea.

src/Neo/SmartContract/Native/Treasury.cs

Co-authored-by: Erik Zhang <[email protected]>

src/Neo/SmartContract/Native/Treasury.cs

AnnaShaleva

Unit-tests are failing.

Jim8y · 2025-11-06T09:57:41Z

src/Neo/SmartContract/Native/Treasury.cs

+        /// <param name="tokenId">Nep11 token Id</param>
+        /// <param name="data">Optional data</param>
+        [ContractMethod(CpuFee = 1 << 15, RequiredCallFlags = CallFlags.States)]
+        private void OnNEP11Payment(ApplicationEngine engine, UInt160 from, BigInteger amount, byte[] tokenId, StackItem data) { }


1<<15 for an empty payment callback?

We can use just 1

@AnnaShaleva do you have a cost estimation of empty calls?

Not yet, but we may include native method prices evaluation to nspcc-dev/neo-go#4043. @Turalchik is working on this issue right now.

For now I agree to use 1, later we may upgrade prices in a subsequent hardfork once benchmarks are done.

Ref. nspcc-dev/neo-go#4043 (comment), ref. #3894.

Init Treasury

42310ed

shargon requested a review from erikzhang November 4, 2025 13:13

vncoelho reviewed Nov 4, 2025

View reviewed changes

erikzhang reviewed Nov 4, 2025

View reviewed changes