Allow spaces (and any other characters that work on the platform) in paths #327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ps1 on win b/c easier to quote properly
…to allow-weird-paths
|
Cool! I never had the time to dig into the weird behavior of windows. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here I am removing
validate_pathsince we should be able to use any valid path. This first commit just removes validate_path and tweaks the tests so that each batch path has a space in it. As a result, most of the tests fail and print "Error: Got unexpected extra argument (batch.pickle)". I am planning to useshlex.quoteandmslex.quoteto fix the subprocess backend so this isn't a problem.See comments on #304.