-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Upgrade react-calendar from 4.1.0 to 4.8.0 #365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Snyk has created this PR to upgrade react-calendar from 4.1.0 to 4.8.0. See this package in npm: react-calendar See this project in Snyk: https://app.snyk.io/org/newtonombese1/project/d92f77c7-4d21-4560-a1c1-675c45b5ed71?utm_source=github&utm_medium=referral&page=upgrade-pr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @nejidevelops, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
I've initiated an automated dependency upgrade for react-calendar
from version 4.1.0
to 4.8.0
. This update aims to keep our project's dependencies current, incorporating numerous improvements, new features, and bug fixes from the react-calendar
library over several minor versions. This ensures we benefit from the latest enhancements and maintain a robust dependency tree.
Highlights
- Dependency Upgrade: The primary change is the upgrade of the
react-calendar
library from version4.1.0
to4.8.0
. This update spans 10 minor versions of the library, bringing a significant number of improvements and fixes. - New Features and Developer Experience: The updated
react-calendar
introduces support for new props likeshowNeighboringCentury
andshowNeighboringDecade
. It also improves developer experience by moving prop documentation to JSDoc and enhances React Server Components (RSC) compatibility. - Type System Enhancements: Several types (
OnArgs
,TileArgs
,NavigationLabelFunc
,OnClickFunc
,OnClickWeekNumberFunc
,TileClassNameFunc
,TileContentFunc
,TileDisabledFunc
,CalendarProps
) are now exported for easier custom callback creation and component typing. Type accuracy for thevalue
prop and various callbacks has also been improved. - Internal Refinements and Performance: Internal refactorings include support for native ESM modules, improved propTypes, strengthened TypeScript types, and a rewrite using React Hooks, which has led to a smaller bundle size. The library also replaced
tiny-warning
with the more popularwarning
package and updated itsclsx
dependency. - Lockfile Updates: The
package-lock.json
file reflects thereact-calendar
version bump, an update toclsx
from1.2.1
to2.1.1
, and the addition ofwarning
as a new dependency. It also adjusts peer dependency metadata for@types/prop-types
,@types/react
, and@types/scheduler
.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, automatically generated by Snyk, upgrades react-calendar
from version 4.1.0 to 4.8.0. The upgrade appears to be safe, as the release notes do not indicate any breaking changes that would affect this project. However, I've found an issue in the package-lock.json
file where the project name has been incorrectly changed. This should be corrected before merging.
@@ -1,11 +1,11 @@ | |||
{ | |||
"name": "Bofulo-School", | |||
"name": "relock-npm-lock-v2-aD7c25", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The package name in package-lock.json
has been changed to a generated-looking string "relock-npm-lock-v2-aD7c25". This should be reverted to the original package name, "Bofulo-School", to maintain project consistency and avoid potential issues with tooling that relies on this name.
"name": "Bofulo-School",
Snyk has created this PR to upgrade react-calendar from 4.1.0 to 4.8.0.
ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.
The recommended version is 10 versions ahead of your current version.
The recommended version was released 2 years ago.
Release notes
Package name: react-calendar
What's new?
showNeighboringCentury
andshowNeighboringDecade
props.`What's changed?
tiny-warning
with more popular (and equally tiny!)warning
.Bug fixes
What's new?
What's new?
OnArgs
type to make it easier to create customon…
callbacks (#897). Thanks, @ meszaros-lajos-gyorgy!TileArgs
type to make it easier to create customtileClassName
,tileContent
,tileDisabled
functions.Bug fixes
calendarType
prop (#902). Thanks, @ abukati!What's new?
What's changed?
Bug fixes
What's new?
'use client';
to the parent component for this component to work.Bug fixes
@ types/react
and@ types/react-dom
are now optional peerDependencies, which eliminates errors caused by duplicate typings.What's new?
NavigationLabelFunc
,OnClickFunc
,OnClickWeekNumberFunc
,TileClassNameFunc
,TileContentFunc
andTileDisabledFunc
types are now exported for your convenience.What's changed?
calendarType
prop to matchIntl.Locale.calendar
. Thanks to this change, we will be able to support many more calendar types in the near future! Don't worry - old values are still supported, but will be deprecated in the future.clsx
dependency to2.0.0
to enable ESM support in the near future.Thanks to internal improvements, this is our smallest release ever, down to just 10kB Gzipped! 🥳
What's new?
CalendarProps
type is now exported for your convenience (#866).Bug fixes
[Date, Date]
instead ofDate[]
).onDrillDown
andonDrillUp
props.tileClassName
not allowingnull
orundefined
return values.React.ComponentProps<typeof Calendar>
incorrectly marking props with default values as required.What's new?
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information: