Skip to content

[Snyk] Upgrade react-calendar from 4.1.0 to 4.8.0 #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nejidevelops
Copy link
Owner

snyk-top-banner

Snyk has created this PR to upgrade react-calendar from 4.1.0 to 4.8.0.

ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.


  • The recommended version is 10 versions ahead of your current version.

  • The recommended version was released 2 years ago.

Release notes
Package name: react-calendar
  • 4.8.0 - 2024-01-09

    What's new?

    • Added support for showNeighboringCentury and showNeighboringDecade props.`

    What's changed?

    • Replaced tiny-warning with more popular (and equally tiny!) warning.

    Bug fixes

    • Fixed disabled neighboring tiles text color.
  • 4.7.0 - 2023-12-09

    What's new?

    • Improved developer experience by moving prop documentation to JSDoc. This means that you can now see descriptions, default values, and examples for all props in your IDE.
    • Improved documentation.
  • 4.6.1 - 2023-10-18

    What's new?

    • Package is now published with npm provenance statements.
    • Exported OnArgs type to make it easier to create custom on… callbacks (#897). Thanks, @ meszaros-lajos-gyorgy!
    • Exported TileArgs type to make it easier to create custom tileClassName, tileContent, tileDisabled functions.

    Bug fixes

    • Fix weekend indicators ignoring calendarType prop (#902). Thanks, @ abukati!
  • 4.6.0 - 2023-07-27

    What's new?

    • Added support for native ESM modules (#886).

    What's changed?

    • Improved propTypes.
    • Strengthened TypeScript types.
    • Refactored tile rendering.

    Bug fixes

    • Fixed propTypes declared twice in every declaration file.
  • 4.5.0 - 2023-07-21

    What's new?

    • Improved RSC compatibility. You no longer need to add 'use client'; to the parent component for this component to work.

    Bug fixes

    • @ types/react and @ types/react-dom are now optional peerDependencies, which eliminates errors caused by duplicate typings.
  • 4.4.0 - 2023-07-16

    What's new?

    • NavigationLabelFunc, OnClickFunc, OnClickWeekNumberFunc, TileClassNameFunc, TileContentFunc and TileDisabledFunc types are now exported for your convenience.

    What's changed?

    • Renamed calendar types passed to calendarType prop to match Intl.Locale.calendar. Thanks to this change, we will be able to support many more calendar types in the near future! Don't worry - old values are still supported, but will be deprecated in the future.
    • Updated clsx dependency to 2.0.0 to enable ESM support in the near future.
  • 4.3.0 - 2023-06-13

    Thanks to internal improvements, this is our smallest release ever, down to just 10kB Gzipped! 🥳

    What's new?

    • CalendarProps type is now exported for your convenience (#866).
    • Rewritten package using React Hooks (#858).
    • Improved RTL language support (#841).
  • 4.2.1 - 2023-04-04

    Bug fixes

    • Improved type accuracy for value prop and all callbacks (it's now explicitly [Date, Date] instead of Date[]).
    • Fixed types for onDrillDown and onDrillUp props.
    • Fixed types for tileClassName not allowing null or undefined return values.
    • Fixed React.ComponentProps<typeof Calendar> incorrectly marking props with default values as required.
  • 4.2.0 - 2023-04-04

    What's new?

    • Allowed array of strings to be passed as value.
  • 4.1.1 - 2023-04-03
  • 4.1.0 - 2023-03-26
from react-calendar GitHub release notes

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.

For more information:

Snyk has created this PR to upgrade react-calendar from 4.1.0 to 4.8.0.

See this package in npm:
react-calendar

See this project in Snyk:
https://app.snyk.io/org/mohammadnewton/project/c13a24ee-19f5-4ec3-b2b5-0ec74165414f?utm_source=github&utm_medium=referral&page=upgrade-pr
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @nejidevelops, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

I've opened this pull request to update the react-calendar dependency from version 4.1.0 to 4.8.0. This upgrade, automatically generated by Snyk, aims to keep our project's dependencies current, ensuring we benefit from the latest features, performance improvements, and bug fixes. The changes primarily involve updating the version in package.json and package-lock.json, which also pulls in updated sub-dependencies and adjusts how some peer dependencies are managed in the lockfile.

Highlights

  • Dependency Upgrade: react-calendar: The primary change in this PR is the upgrade of the react-calendar library from version 4.1.0 to 4.8.0. This is a significant jump, covering 10 minor versions and bringing numerous improvements and new features.
  • New Features and Developer Experience: The react-calendar update introduces new props like showNeighboringCentury and showNeighboringDecade for enhanced navigation, and improves developer experience through better JSDoc documentation and the export of various types (OnArgs, TileArgs, CalendarProps) for increased type safety and customizability.
  • Performance and Compatibility Enhancements: Several internal improvements have been made, including a rewrite using React Hooks, improved RSC (React Server Components) compatibility, native ESM module support, and a reduction in bundle size (version 4.3.0 was noted as the 'smallest release ever'). The clsx dependency was also updated, and tiny-warning was replaced with warning.
  • Bug Fixes and Type Improvements: The update also includes various bug fixes, such as correcting disabled neighboring tiles text color and addressing issues with weekend indicators ignoring the calendarType prop. Type accuracy for props and callbacks has also been improved.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This PR upgrades react-calendar from 4.1.0 to 4.8.0. This is a large update with many changes, including a rewrite to use React Hooks. The release notes suggest backward compatibility is maintained. My review of the codebase suggests react-calendar is an unused dependency. If so, consider removing it instead of upgrading. I've also found an issue with the project name in package-lock.json being changed to an auto-generated value, which I've commented on separately. The overall risk of this upgrade is low since the dependency appears unused.

@@ -1,11 +1,11 @@
{
"name": "Bofulo-School",
"name": "relock-npm-lock-v2-uP84tu",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The name of the project in package-lock.json has been changed from "Bofulo-School" to "relock-npm-lock-v2-uP84tu". This new name appears to be auto-generated and may indicate that the package-lock.json file was regenerated in an environment where the project name from package.json was not available. While this might not cause immediate issues, it's best to ensure the package.json has a name field and that the package-lock.json reflects the correct project name for consistency and to avoid potential issues with tooling that relies on this metadata. It's recommended to add a name to package.json and regenerate the lock file to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants