-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Upgrade react-calendar from 4.1.0 to 4.8.0 #363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Snyk has created this PR to upgrade react-calendar from 4.1.0 to 4.8.0. See this package in npm: react-calendar See this project in Snyk: https://app.snyk.io/org/mohammadnewton/project/c13a24ee-19f5-4ec3-b2b5-0ec74165414f?utm_source=github&utm_medium=referral&page=upgrade-pr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @nejidevelops, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request is an automated dependency upgrade initiated by Snyk to update the react-calendar
library to its latest stable version, 4.8.0
. The upgrade aims to keep project dependencies current, enhance security by addressing potential vulnerabilities, and leverage the latest features and performance improvements offered by the library.
Highlights
- Dependency Upgrade: The primary change in this pull request is the upgrade of the
react-calendar
library from version4.1.0
to4.8.0
. This update incorporates numerous new features, bug fixes, and performance improvements from the upstream library. - New Features & Improvements: The upgraded
react-calendar
includes support for new props likeshowNeighboringCentury
andshowNeighboringDecade
, improved developer experience with JSDoc prop documentation, native ESM module support, enhanced React Server Components (RSC) compatibility, and a rewrite using React Hooks for better performance and smaller bundle size. - Dependency Graph Updates: The
package-lock.json
file has been updated to reflect the newreact-calendar
version, including an upgrade of its internalclsx
dependency to2.1.1
and the addition of a newwarning
dependency. Several@types
packages (@types/prop-types
,@types/react
,@types/scheduler
,csstype
) are now explicitly marked as optional peer dependencies, and new top-level entries forreact
,react-dom
, andscheduler
have been added to the lockfile.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This PR upgrades react-calendar
from version 4.1.0 to 4.8.0. The changes in package.json
and package-lock.json
correctly reflect this version bump and its transitive dependency updates.
However, I've found one critical issue in package-lock.json
where the project's name has been unintentionally changed. This should be reverted to prevent potential issues with your build process or other tooling. Please see the detailed comment.
@@ -1,11 +1,11 @@ | |||
{ | |||
"name": "Bofulo-School", | |||
"name": "relock-npm-lock-v2-MUWEQl", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The package name in package-lock.json
has been changed from Bofulo-School
to relock-npm-lock-v2-MUWEQl
. This appears to be an artifact from an automated tool and should be reverted to the original name. An incorrect package name can cause issues with npm, build tools, and continuous integration pipelines that may rely on this value.
"name": "Bofulo-School",
Snyk has created this PR to upgrade react-calendar from 4.1.0 to 4.8.0.
ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.
The recommended version is 10 versions ahead of your current version.
The recommended version was released 2 years ago.
Release notes
Package name: react-calendar
What's new?
showNeighboringCentury
andshowNeighboringDecade
props.`What's changed?
tiny-warning
with more popular (and equally tiny!)warning
.Bug fixes
What's new?
What's new?
OnArgs
type to make it easier to create customon…
callbacks (#897). Thanks, @ meszaros-lajos-gyorgy!TileArgs
type to make it easier to create customtileClassName
,tileContent
,tileDisabled
functions.Bug fixes
calendarType
prop (#902). Thanks, @ abukati!What's new?
What's changed?
Bug fixes
What's new?
'use client';
to the parent component for this component to work.Bug fixes
@ types/react
and@ types/react-dom
are now optional peerDependencies, which eliminates errors caused by duplicate typings.What's new?
NavigationLabelFunc
,OnClickFunc
,OnClickWeekNumberFunc
,TileClassNameFunc
,TileContentFunc
andTileDisabledFunc
types are now exported for your convenience.What's changed?
calendarType
prop to matchIntl.Locale.calendar
. Thanks to this change, we will be able to support many more calendar types in the near future! Don't worry - old values are still supported, but will be deprecated in the future.clsx
dependency to2.0.0
to enable ESM support in the near future.Thanks to internal improvements, this is our smallest release ever, down to just 10kB Gzipped! 🥳
What's new?
CalendarProps
type is now exported for your convenience (#866).Bug fixes
[Date, Date]
instead ofDate[]
).onDrillDown
andonDrillUp
props.tileClassName
not allowingnull
orundefined
return values.React.ComponentProps<typeof Calendar>
incorrectly marking props with default values as required.What's new?
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information: