Replace jh-single-native-proxy for oauth2-proxy #611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
viniciusdc
commented
May 13, 2025
Comment on lines
+128
to
+137
| # @click.command() | ||
| # @click.option('--destport', default=0, help='port that the webapp should end up running on; default 0 to be assigned a random free port') | ||
| # @click.option('--ip', default=None, help='Address to listen on') | ||
| # @click.option('--presentation-path', default='', help='presentation_path substitution variable') | ||
| # @click.option('--debug/--no-debug', default=False, help='To display debug level logs') | ||
| # @click.option('--logs/--no-logs', default=True, help='To display logs generated by the subprocess') | ||
| # @click.option('--authtype', type=click.Choice(['oauth', 'none'], case_sensitive=True), default='oauth') | ||
| # @click.option('--request-timeout', default=300, type=click.INT, help='timeout of proxy http calls to subprocess in seconds (default 300)') | ||
| # @click.option('--force-alive/--no-force-alive', default=False, help='Force the process to stay alive even if it is not ready') | ||
| # @click.option('--ready-check-path', default='/', help='URL path to poll for readiness (default /)') |
There was a problem hiding this comment.
I will remove all this later on, just left here to keep some backward compatibility
|
I am not entirely sure about how to handle credentials, for example, if we want to use ouath2 from keycloak as the method of authentication, we will need to pass over the client name and secret into oauth2-proxy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues or PRs
What does this implement/fix?
Put a
xin the boxes that applyTesting
Documentation
Access-centered content checklist
Text styling
H1or#in markdown).Non-text content
Any other comments?