Skip to content

Feat/generic signer verifier #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 16, 2024
Merged

Feat/generic signer verifier #529

merged 3 commits into from
Dec 16, 2024

Conversation

ilteoood
Copy link
Contributor

@ilteoood ilteoood commented Dec 14, 2024 •
edited
Loading

To be reviewed after #528
Closes #225

simoneb
simoneb approved these changes Dec 15, 2024
View reviewed changes
Copy link
Member

@simoneb simoneb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look like a breaking change but I'm not terribly familiar with TS's idiosincrasies. Thoughts?

@simoneb simoneb requested a review from Copilot December 15, 2024 14:30
Copilot
Copilot AI reviewed Dec 15, 2024
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • package.json: Language not supported

@ilteoood
Copy link
Contributor Author

@simoneb It shouldn't, since we are providing a default for each generic

@simoneb simoneb requested a review from Copilot December 16, 2024 17:52
Copilot
Copilot AI reviewed Dec 16, 2024
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

@simoneb simoneb merged commit 15f0f8d into nearform:master Dec 16, 2024
6 checks passed
@optic-release-automation optic-release-automation bot mentioned this pull request Dec 16, 2024
Merged
@github-actions github-actions bot mentioned this pull request Dec 22, 2024
Closed
This was referenced Jan 14, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@simoneb simoneb simoneb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add generic types to create functions
2 participants
@ilteoood @simoneb