-
Notifications
You must be signed in to change notification settings - Fork 2
Simon/snapshots #218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Simon/snapshots #218
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #218 +/- ##
==========================================
+ Coverage 87.95% 88.11% +0.16%
==========================================
Files 48 49 +1
Lines 9131 9366 +235
Branches 9131 9366 +235
==========================================
+ Hits 8031 8253 +222
- Misses 653 661 +8
- Partials 447 452 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1faa085 to
3720e8f
Compare
gilcu3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not find any big issue, but did have a lot of suggestions, therefore marking the review as "Request changes". Most of them should be quite easy to solve though.
Once that is done, I can do a quick pass again and approve.
netrome
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nits from my side, but overall I think it looks good. I agree with the general comments about test organization from Reynaldo.
The only blockers I see are:
- Some docstrings are a bit confusing right now.
- The tests that use OsRng should be made deterministic.
gilcu3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the updates! Left a couple of nits
Closes #145