Skip to content

Conversation

@PolyProgrammist
Copy link
Collaborator

No description provided.

assert!(logs.contains(&(expected.as_str())));

match res.receipt_outcomes()[5].clone().into_result()? {
match res.receipt_outcomes()[4].clone().into_result()? {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have any ideas why ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested examples in near-sdk-rs

There is a problem in fungible-token example. The thing is, for 2.6.5, ft_on_transfer:

ExecutionOutcome { transaction_hash: 8zMYKktbBaZNMy1tZu6nn8rFTogAPRpvzPFB9tesng6k, block_hash: BEjaxftMNEgcjnMUH8QE9cPrYAticiMPaQUJm5oiQ73z, logs: [
            "in 100000000000000000000000000 tokens from @dev-20251010160720-35098875556643.test.near ft_on_transfer, msg = 10"
        ], receipt_ids: [Geqfk5ezMxsownv8R4HX5mEUGMpCWciGvY6bV2bvuTtS,
            2YjdWAY2e6Wo7oH4cC2VsSbcgm1qWvaxSqCSBErixb6x
        ], gas_burnt: NearGas { inner: 1659059067055
        }, tokens_burnt: NearToken { inner: 165905906705500000000
        }, executor_id: AccountId("dev-20251010160722-47457130458526.test.near"), status: SuccessReceiptId(Geqfk5ezMxsownv8R4HX5mEUGMpCWciGvY6bV2bvuTtS)
    }

generates 2 receipts:

ExecutionOutcome { transaction_hash: Geqfk5ezMxsownv8R4HX5mEUGMpCWciGvY6bV2bvuTtS, block_hash: 54mTiw53d2Vy6wjJe8bW2YLxYBUQ5U2oSkK3Gif8YZVr, logs: [
            "in value_please, amount_to_return = 10"
        ], receipt_ids: [F1B5CiR9yTqpp6AzTdDvwxi8Aw5joQjA9TEDhrR5PXpj
        ], gas_burnt: NearGas { inner: 1096289563699
        }, tokens_burnt: NearToken { inner: 109628956369900000000
        }, executor_id: AccountId("dev-20251010160722-47457130458526.test.near"), status: SuccessValue('"10"')
    }

and:

ExecutionOutcome { transaction_hash: 2YjdWAY2e6Wo7oH4cC2VsSbcgm1qWvaxSqCSBErixb6x, block_hash: 54mTiw53d2Vy6wjJe8bW2YLxYBUQ5U2oSkK3Gif8YZVr, logs: [], receipt_ids: [], gas_burnt: NearGas { inner: 223182562500
        }, tokens_burnt: NearToken { inner: 0
        }, executor_id: AccountId("dev-20251010160720-35098875556643.test.near"), status: SuccessValue('')
    }

While the second receipt is not generated on both 2.7.0 and 2.8.0

I believe it's this near/NEPs#536 - reduction of the number of refund receipts

@codecov
Copy link

codecov bot commented Nov 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.88%. Comparing base (5cc4fcf) to head (dd1332f).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1398      +/-   ##
==========================================
+ Coverage   80.87%   80.88%   +0.01%     
==========================================
  Files         104      104              
  Lines       15464    15470       +6     
==========================================
+ Hits        12506    12513       +7     
+ Misses       2958     2957       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@race-of-sloths score 2

@race-of-sloths
Copy link

race-of-sloths commented Nov 7, 2025

@PolyProgrammist Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
King of Sloths shakes your hand! Yellow leader's jersey is yours deservedly!

Shows inviting banner with latest news.

Shows profile picture for the author of the PR

Current status: executed
Reviewer Score
@frol 2

Your contribution is much appreciated with a final score of 2!
You have received 20 Sloth points for this contribution

@frol received 25 Sloth Points for reviewing and scoring this pull request.

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths and receive a reward
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

@frol frol merged commit 3f4dffd into near:master Nov 8, 2025
44 checks passed
@github-project-automation github-project-automation bot moved this from NEW❗ to Shipped 🚀 in DevTools Nov 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Shipped 🚀

Development

Successfully merging this pull request may close these issues.

4 participants