-
Notifications
You must be signed in to change notification settings - Fork 267
ci: fix tests #1398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: fix tests #1398
Conversation
| assert!(logs.contains(&(expected.as_str()))); | ||
|
|
||
| match res.receipt_outcomes()[5].clone().into_result()? { | ||
| match res.receipt_outcomes()[4].clone().into_result()? { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have any ideas why ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested examples in near-sdk-rs
There is a problem in fungible-token example. The thing is, for 2.6.5, ft_on_transfer:
ExecutionOutcome { transaction_hash: 8zMYKktbBaZNMy1tZu6nn8rFTogAPRpvzPFB9tesng6k, block_hash: BEjaxftMNEgcjnMUH8QE9cPrYAticiMPaQUJm5oiQ73z, logs: [
"in 100000000000000000000000000 tokens from @dev-20251010160720-35098875556643.test.near ft_on_transfer, msg = 10"
], receipt_ids: [Geqfk5ezMxsownv8R4HX5mEUGMpCWciGvY6bV2bvuTtS,
2YjdWAY2e6Wo7oH4cC2VsSbcgm1qWvaxSqCSBErixb6x
], gas_burnt: NearGas { inner: 1659059067055
}, tokens_burnt: NearToken { inner: 165905906705500000000
}, executor_id: AccountId("dev-20251010160722-47457130458526.test.near"), status: SuccessReceiptId(Geqfk5ezMxsownv8R4HX5mEUGMpCWciGvY6bV2bvuTtS)
}generates 2 receipts:
ExecutionOutcome { transaction_hash: Geqfk5ezMxsownv8R4HX5mEUGMpCWciGvY6bV2bvuTtS, block_hash: 54mTiw53d2Vy6wjJe8bW2YLxYBUQ5U2oSkK3Gif8YZVr, logs: [
"in value_please, amount_to_return = 10"
], receipt_ids: [F1B5CiR9yTqpp6AzTdDvwxi8Aw5joQjA9TEDhrR5PXpj
], gas_burnt: NearGas { inner: 1096289563699
}, tokens_burnt: NearToken { inner: 109628956369900000000
}, executor_id: AccountId("dev-20251010160722-47457130458526.test.near"), status: SuccessValue('"10"')
}and:
ExecutionOutcome { transaction_hash: 2YjdWAY2e6Wo7oH4cC2VsSbcgm1qWvaxSqCSBErixb6x, block_hash: 54mTiw53d2Vy6wjJe8bW2YLxYBUQ5U2oSkK3Gif8YZVr, logs: [], receipt_ids: [], gas_burnt: NearGas { inner: 223182562500
}, tokens_burnt: NearToken { inner: 0
}, executor_id: AccountId("dev-20251010160720-35098875556643.test.near"), status: SuccessValue('')
}While the second receipt is not generated on both 2.7.0 and 2.8.0
I believe it's this near/NEPs#536 - reduction of the number of refund receipts
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1398 +/- ##
==========================================
+ Coverage 80.87% 80.88% +0.01%
==========================================
Files 104 104
Lines 15464 15470 +6
==========================================
+ Hits 12506 12513 +7
+ Misses 2958 2957 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
frol
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@race-of-sloths score 2
|
@PolyProgrammist Thank you for your contribution! Your pull request is now a part of the Race of Sloths! Current status: executed
Your contribution is much appreciated with a final score of 2! @frol received 25 Sloth Points for reviewing and scoring this pull request. What is the Race of SlothsRace of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow For contributors:
For maintainers:
Feel free to check our website for additional details! Bot commands
|
No description provided.