[Feature] add PagerFilterRegexp for StreamPager #715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ripienaar
reviewed
Sep 12, 2025
ripienaar
reviewed
Sep 17, 2025
| } | ||
| } | ||
|
|
||
| filterNextDirectly: |
Collaborator
There was a problem hiding this comment.
Wont this still have the effect of sending to the client less than a page full of messages when some are filtered?
This method would need significant rewriting because it fetches a batch equal to page size, so when we skip one we also need to fetch one so that there is a page full of messages sent when we tell the client we sent a page full.
If the client says he wants 25 messages in a page he needs to get 25 even when 5 were filtered, not 20 and then told its a end of page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To achive the feature in
natsclias nats-io/natscli#1486 described.