Skip to content

Conversation

@ygliuvt
Copy link
Member

@ygliuvt ygliuvt commented Mar 26, 2025

Jira Issue ID

HARMONY-2026

Description

Add support in harmony-py to cancel a job.
Add cancel job example in Jupyter notebook.
Fix broken job preview example in Jupyter notebook.

Local Test Steps

run job_pause_resume.ipynb notebook

PR Acceptance Checklist

  • Acceptance criteria met
  • Tests added/updated (if needed) and passing
  • Documentation updated (if needed)

Copy link
Contributor

@chris-durbin chris-durbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm having issues right now with harmony-py preventing me from running the notebooks. I did see that there are a couple of cells that generate exceptions which cause the notebook to stop executing when you try to run the entire thing at once. We should update both of those cells to use try blocks and catch the exceptions.

Attempting to pause a completed job will result in an error

Attempting to resume a completed job will also result in an error

Copy link
Contributor

@chris-durbin chris-durbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to test everything with cancel successfully after running make clean. Approved assuming we update those two cells to catch and display the exceptions rather than causing the notebook to error on those cells.

@ygliuvt ygliuvt merged commit 38e761e into main Mar 27, 2025
11 checks passed
@ygliuvt ygliuvt deleted the harmony-2026 branch March 27, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants