Skip to content

Conversation

ygliuvt
Copy link
Member

@ygliuvt ygliuvt commented Feb 12, 2025

Jira Issue ID

HARMONY-1900

Description

Add capability to query for jobs using one or more labels in harmony-py.
Refactored harmony.harmony module into harmony.request and harmony.client.

Local Test Steps

Run examples/job_label.ipynb for job searching example.

PR Acceptance Checklist

  • Acceptance criteria met
  • Tests added/updated (if needed) and passing
  • Documentation updated (if needed)

Copy link
Contributor

@indiejames indiejames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally

Copy link
Contributor

@chris-durbin chris-durbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw one cell in the notebook is code, but should be markdown (#### Search jobs by labels).

I think it would be good for the search by labels example in the notebook to show that it ORs the labels. Right now it is not clear because every job that is returned has both the foo and bar labels.

@ygliuvt ygliuvt merged commit 6222df2 into main Feb 12, 2025
11 checks passed
@ygliuvt ygliuvt deleted the harmony-1900 branch February 12, 2025 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants