-
-
Notifications
You must be signed in to change notification settings - Fork 19
Update contributors #198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update contributors #198
Conversation
WalkthroughAdds Zephyr Lykos (MochaaP) to contributors: updates .all-contributorsrc contributors array and README.md to reflect 11 contributors and include the new entry in the All-Contributors table. No code or behavior changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
.all-contributorsrc
(1 hunks)README.md
(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Unit test (linux) (windows-latest, 1)
🔇 Additional comments (2)
README.md (2)
2-2
: Badge bumped to 11 — consistent with current table.Matches contributors count; no issues.
239-239
: New contributor cell renders and links correctly.Avatar, name, and commits link (author=mochaaP) align with config.
}, | ||
{ | ||
"login": "mochaaP", | ||
"name": "Zephyr Lykos", | ||
"avatar_url": "https://avatars.githubusercontent.com/u/21154023?v=4", | ||
"profile": "https://mochaa.ws/?utm_source=github_user", | ||
"contributions": [ | ||
"code" | ||
] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
LGTM: contributor added correctly; JSON remains valid.
Entry for mochaaP (Zephyr Lykos) looks consistent with existing records and All-Contributors expectations.
Run this quick check to ensure README and config stay in sync:
🏁 Script executed:
#!/bin/bash
set -euo pipefail
count="$(jq '.contributors | length' .all-contributorsrc)"
echo "contributors in .all-contributorsrc: $count"
badge="$(rg -nPo 'all_contributors-\K\d+' README.md | head -1)"
echo "badge count in README.md: $badge"
test "$badge" = "$count" || { echo "Mismatch between badge and contributors count"; exit 1; }
rg -n 'commits\?author=mochaaP' README.md >/dev/null || { echo "Missing mochaaP commit link in README"; exit 1; }
echo "OK"
Length of output: 438
Approve contributor addition; fix badge count extraction in verification script
JSON update is correct and mochaaP (Zephyr Lykos) is added as expected. Update the README-sync check to drop the -n
flag so rg
returns only the number, not line:match
:
#!/bin/bash
set -euo pipefail
count="$(jq '.contributors | length' .all-contributorsrc)"
echo "contributors in .all-contributorsrc: $count"
badge="$(rg -Po 'all_contributors-\K\d+' README.md | head -1)"
echo "badge count in README.md: $badge"
test "$badge" = "$count" || { echo "Mismatch between badge and contributors count"; exit 1; }
rg -q 'commits\?author=mochaaP' README.md || { echo "Missing mochaaP commit link in README"; exit 1; }
echo "OK"
🤖 Prompt for AI Agents
In .all-contributorsrc around lines 99 to 107, the README-sync verification
script extracts the badge count with ripgrep using a flag that returns
line:match; update the command to drop the -n flag and use an output-only match
(e.g., rg -Po or rg --only-matching) and pipe to head -1 so it yields just the
numeric badge, then compare that numeric badge to the jq-derived contributors
count and keep the existing README link check for mochaaP.
Code Metrics Report
Details | | main (5db968b) | #198 (a7e6829) | +/- |
|---------------------|----------------|----------------|--------|
+ | Coverage | 86.2% | 86.5% | +0.3% |
| Files | 14 | 14 | 0 |
| Lines | 603 | 603 | 0 |
+ | Covered | 520 | 522 | +2 |
- | Test Execution Time | 19s | 5m9s | +4m50s | Code coverage of files in pull request scope (74.3% → 75.6%)
Reported by octocov |
Summary by CodeRabbit