Add edge-to-edge support #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoontek
commented
Mar 8, 2025
|
|
||
| override fun onCreateDialog(savedInstanceState: Bundle?): Dialog { | ||
| return Dialog(requireActivity(), R.style.Theme_FullScreenDialog).apply { | ||
| setCanceledOnTouchOutside(true) |
There was a problem hiding this comment.
I kept the ImageViewerDialogFragment behavior, just changed the applied theme on the Dialog instance.
zoontek
commented
Mar 8, 2025
| return Dialog(requireActivity(), R.style.Theme_FullScreenDialog).apply { | ||
| setCanceledOnTouchOutside(true) | ||
|
|
||
| window?.let { |
There was a problem hiding this comment.
Here we enters edge-to-edge, and set the system bars colors based on the chosen theme. It's safe as it operates in a different Window (the Dialog one, compared to the MainActivity one), so it will not mess with SystemBars, StatusBar, etc.
alantoa
approved these changes
Mar 8, 2025
hirbod
approved these changes
Mar 10, 2025
|
good to merge? |
nandorojo
reviewed
Mar 10, 2025
|
@nandorojo Totally, yes |
This was referenced Mar 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
edge-to-edge.mp4
Following https://github.com/nandforojo/galeria/issues/16 (ping @hirbod)
This PR add support for edge-to-edge layout. It adds a new prop:
edgeToEdge, that is alwaystruewhenreact-native-edge-to-edgeis installed.I would recommand to expose the
edgeToEdgeprop in the TypeScript types for nonreact-native-edge-to-edgeusers that also wants edge-to-edge (currently, it's not, check theGaleriaViewPropstype vs the actual acceptedGaleriaprops).