Convert ToastContainer to Script Setup to fix type errors #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nandi95
previously approved these changes
Mar 1, 2025
nandi95
approved these changes
Mar 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
#54
❓ Type of change
📚 Description
As mentioned in the TS fixes PR (#53), this fixes the remaining type errors I was seeing in
ToastContainerby converting it to usingscript setup. Conveniently, thejsxPR doesn't touchToastContainer, so there will be no conflicts.This has been updated to add in the fix for #54 - preventing duplication of queued toasts. It also fixes an off-by-one bug which prevented the number of toasts from reaching maxToasts until queued toasts were released.
📝 Checklist