refactor(ensindexer): make use config singleton instance #766
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to defer
ENSIndexerConfigexecution by returning the config object on demand to callers ofconfig()getter function. It's different than previous approach, where all callers would read value of the default export from@/config.This change aims to fix Typescript issue of circular type inference:
Also, this PR makes the
handlersproperty ofENSIndexerPluginto be a function that returns a list of async imports. This aims to defer runtime making these imports. This is another attempt to break Typescript circular inference.