Skip to content

Conversation

@tk-o
Copy link
Contributor

@tk-o tk-o commented May 31, 2025

This PR aims to defer ENSIndexerConfig execution by returning the config object on demand to callers of config() getter function. It's different than previous approach, where all callers would read value of the default export from @/config.

This change aims to fix Typescript issue of circular type inference:

implicitly has type 'any' because it does not have a type annotation and is referenced directly or indirectly in its own initializer.ts(7022)

Also, this PR makes the handlers property of ENSIndexerPlugin to be a function that returns a list of async imports. This aims to defer runtime making these imports. This is another attempt to break Typescript circular inference.

@changeset-bot
Copy link

changeset-bot bot commented May 31, 2025

⚠️ No Changeset found

Latest commit: ca367d6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented May 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
admin.ensnode.io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 2, 2025 9:22am
ensnode.io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 2, 2025 9:22am
ensrainbow.io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 2, 2025 9:22am

@tk-o
Copy link
Contributor Author

tk-o commented Jun 2, 2025

Closing in favour of #765

@tk-o tk-o closed this Jun 2, 2025
@lightwalker-eth lightwalker-eth deleted the fix/ensindexer-plugin-types branch January 17, 2026 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants