-
Notifications
You must be signed in to change notification settings - Fork 15
feat(apps/ensadmin): show more social links on name page #1071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 8b51523 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
shrugs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the addition to the default record set LGTM. but i'm concerned about the formatting changes that make me think linting is slightly misconfigured on your editing machine - can you check up on it?
packages/ensnode-sdk/src/resolution/default-records-selection.ts
Outdated
Show resolved
Hide resolved
packages/ensnode-sdk/src/resolution/default-records-selection.ts
Outdated
Show resolved
Hide resolved
|
re: linting, i previously had issues if i opened the project folder directly — if i open the monorepo folder in vscode/cursor then linting works as expected. and yeah looks like biome:ci is complaining, so something is mis-configured. let me know what the solution ends up being — the defaults should just work for everyone |
lightwalker-eth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@notrab Hey super to see this 😄 Reviewed and shared a suggestion 👍
Co-authored-by: lightwalker.eth <[email protected]>
|
note that i have move the components to |
lightwalker-eth
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is now approved and ready to merge from my perspective.
Closes #1069
There are some layout decisions to be made. Personally, I like this on desktop/mobile:
But, this is stacked links on desktop:
