Skip to content

Conversation

@notrab
Copy link
Member

@notrab notrab commented Sep 15, 2025

Closes #1069

There are some layout decisions to be made. Personally, I like this on desktop/mobile:

CleanShot 2025-09-15 at 16 45 13@2x CleanShot 2025-09-15 at 16 45 41@2x

But, this is stacked links on desktop:
CleanShot 2025-09-15 at 16 45 50@2x

@notrab notrab requested a review from a team as a code owner September 15, 2025 17:53
@changeset-bot
Copy link

changeset-bot bot commented Sep 15, 2025

🦋 Changeset detected

Latest commit: 8b51523

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
ensadmin Minor
ensindexer Minor
ensrainbow Minor
@ensnode/datasources Minor
@ensnode/ensrainbow-sdk Minor
@ensnode/ponder-metadata Minor
@ensnode/ensnode-schema Minor
@ensnode/ensnode-react Minor
@ensnode/ponder-subgraph Minor
@ensnode/ensnode-sdk Minor
@ensnode/shared-configs Minor
@docs/ensnode Minor
@docs/ensrainbow Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Sep 15, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
admin.ensnode.io Ready Ready Preview Comment Sep 18, 2025 4:57pm
ensnode.io Ready Ready Preview Comment Sep 18, 2025 4:57pm
ensrainbow.io Ready Ready Preview Comment Sep 18, 2025 4:57pm

@notrab notrab changed the title docs(changeset): get social coin types for telegram, linkedin and reddit feat(apps/ensadmin): show more social links on name page Sep 15, 2025
Copy link
Collaborator

@shrugs shrugs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the addition to the default record set LGTM. but i'm concerned about the formatting changes that make me think linting is slightly misconfigured on your editing machine - can you check up on it?

@shrugs
Copy link
Collaborator

shrugs commented Sep 15, 2025

re: linting, i previously had issues if i opened the project folder directly — if i open the monorepo folder in vscode/cursor then linting works as expected.

and yeah looks like biome:ci is complaining, so something is mis-configured. let me know what the solution ends up being — the defaults should just work for everyone

Copy link
Member

@lightwalker-eth lightwalker-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@notrab Hey super to see this 😄 Reviewed and shared a suggestion 👍

@shrugs
Copy link
Collaborator

shrugs commented Sep 17, 2025

note that i have move the components to _components because that's the correct pattern for page-specific components, as far as i'm aware

Copy link
Member

@lightwalker-eth lightwalker-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is now approved and ready to merge from my perspective.

@lightwalker-eth lightwalker-eth mentioned this pull request Sep 18, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expand Social Records on Name Detail page

4 participants