Fix for Growing Multiline Inputs in RN > 0.40 #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In more recent version of RN, the onContentSizeChange is only called with the initial size, and onChange is called thereafter. See facebook/react-native#6552 (comment) 962
Owner
|
Thanks for reporting, looks like it works in RN 0.42 but is broken again in RN 0.44. Update: iOS works as expected in RN 0.44 |
Owner
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In more recent version of RN, the onContentSizeChange is only called
with the initial size, and onChange is called thereafter. This commit points the TextInput onChange listener to the same function as onContentSizeChange so that growing multiline inputs work again. See
facebook/react-native#6552 (comment)
962 & facebook/react-native#1229 (comment)