Skip to content

Conversation

jkirschner
Copy link

@jkirschner jkirschner commented Oct 6, 2020

This is a modified version of #309 that cleans up some of the commit history and removes functionality that will be obsoleted by a subsequent formula.js integration PR.

According to ChieveiT, it does the following:

@jkirschner
Copy link
Author

@myliang : any thoughts on this PR? (e.g., too large, or don't like the proposed changes, or like the proposed changes but want to see it refactored)

@jkirschner
Copy link
Author

@myliang : happy to make changes (and may ask ChieveiT for help) if there's something the maintainers don't like.

@jkirschner
Copy link
Author

@myliang : what are your thoughts on this PR?

@myliang
Copy link
Owner

myliang commented Feb 21, 2021

@myliang : what are your thoughts on this PR?

you should split and push

@jkirschner
Copy link
Author

@myliang : just confirming that I understand, you want me to decrease the size of this PR by splitting into smaller changes?

@jkirschner
Copy link
Author

jkirschner commented May 13, 2021

@myliang - I've split off the first three commits from this PR into individual PRs:

I've also updated this PR to just include the final commit (better formula editing) for your review.

@jkirschner jkirschner marked this pull request as draft May 13, 2021 14:14
@jkirschner jkirschner force-pushed the better-formula-editing branch from 25d10f5 to ee61ed6 Compare May 13, 2021 15:11
@jkirschner jkirschner marked this pull request as ready for review May 13, 2021 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants