forked from Azure/caf-terraform-landingzones
-
Notifications
You must be signed in to change notification settings - Fork 0
[pull] master from Azure:master #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pull
wants to merge
128
commits into
mySMB:master
Choose a base branch
from
Azure:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to source pipeline yamls from Github (non public repos), we need to create a service connection. This commit updates the service endpoint functionality to understand a 'type' value. For the existing configs, default type to 'TfsGit' if none is specified. If type is set to 'Github', then use the new logic under azdo_service_endpoint.github.tf to provision the connection. The various values for 'type' are shown at https://registry.terraform.io/providers/microsoft/azuredevops/latest/docs/resources/build_definition#repo_type - however this commit only implements Github. A similar pattern should be possible to implement Bitbucket / GitHubEnterprise. The following shows an example config to use this new functionality: service_endpoints = { github = { endpoint_name = "github_endpoint" type = "Github" project_key = "project_to_add_endpoint_to" keyvault = { lz_key = "launchpad" key = "secrets" secret_name = "github-pat" } } } NOTE: similar to azdo-pat-admin, a Github PAT must be manually created and stored in the keyvault identified in the 'keyvault {}' block above: $ az keyvault secret set --name gitub-pat --vault-name <secrets-vault> --value <pat>
To resolve error below" Error: Failed to query available provider packages Could not retrieve the list of available versions for provider hashicorp/azurerm: no available releases match the given constraints ~> 2.55.0, ~> 2.81.0
update version and remove unused var
Upgrading 2112.int to module 5.5.1
…_vwan Add ability to specify vwan_key for virtual hubs that are part of a virtual WAN
add-ons/azure_devops_v1: add service endpoints for Azure container registry
Revert 291 feature/azdo group perms
January 2022 Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )