Support newer versions of sphinx gallery #1334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for making this pull request. Did you know? You can try it on Binder: Also, the version of Jupytext developed in this PR can be installed with (this requires |
|
Hello @thomasjpfan , thank you for this PR! I will review and test it shortly. |
|
Thanks for working on this @thomasjpfan ! |
mwouts
force-pushed
the
support_newer_sphinx_gallery
branch
from
b6820ed to
4bad5bb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1334 +/- ##
==========================================
+ Coverage 96.97% 97.01% +0.04%
==========================================
Files 32 32
Lines 4895 4894 -1
==========================================
+ Hits 4747 4748 +1
+ Misses 148 146 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Thank you @thomasjpfan for your PR, it's great to see this fixed! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, the newer versions of sphinx gallery can be used with
jupytext.Sphinx-gallery has kept the rst2cmd function signature since 0.8.0:
0.8.0: https://github.com/sphinx-gallery/sphinx-gallery/blob/05cc570f62dbe4b71ddc57832ba119fc5457ea0d/sphinx_gallery/notebook.py#L72master: https://github.com/sphinx-gallery/sphinx-gallery/blob/f84a7af3459c053124c34c4c53037228689d3656/sphinx_gallery/notebook.py#L96As for the changes, the API for headers is tested by sphinx gallery:
https://github.com/sphinx-gallery/sphinx-gallery/blob/05cc570f62dbe4b71ddc57832ba119fc5457ea0d/sphinx_gallery/tests/test_notebook.py#L146-L148
And setting
gallery_conf = {"notebook_images": False}skips any image embedding:https://github.com/sphinx-gallery/sphinx-gallery/blob/f84a7af3459c053124c34c4c53037228689d3656/sphinx_gallery/notebook.py#L192-L193