Add weighted estimation in function interface #3586
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-on to #3580
This adds
weights
as an option inlineplot
,barplot
,pointplot
, along with the corresponding figure-level functions.Note that we are going to have to live with the unfortunate contrast between
weights=
in the function interface andweight=
in the object interface. That maintains local consistency (the distribution plot functions already useweights
, while the objects interface has a strong singular parameter name convention) at the cost of global consistency. Given that the parameter naming scheme already differs between the two interfaces, I suppose that I can live with it.As in
objects.Est
, the use ofweights
currently limits the statistical options toestimator="mean", errorbar="ci"
. We'd need to add support for other estimators/errorbars on a case-by-case basis. Note that we shouldn't need to make changes in the interface functions to do so as all of the input checking logic is handled by the underlying statistical objects.We may want to add
weights
to violinplot as well. That would look fairly different so it can go in a separate PR. I haven't investigated how complicated it would be. I think that weighted box/boxenplots are probably out of scope.Closes #3563