Skip to content

COMPAT: Change pandas use_inf_as_null to reflect 2.0 deprecation #3177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2022
+3 −3
Merged

COMPAT: Change pandas use_inf_as_null to reflect 2.0 deprecation #3177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion seaborn/_core/plot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1484,7 +1484,7 @@ def split_generator(keep_na=False) -> Generator:

axes_df = self._filter_subplot_data(df, view)

with pd.option_context("mode.use_inf_as_null", True):
with pd.option_context("mode.use_inf_as_na", True):
if keep_na:
# The simpler thing to do would be x.dropna().reindex(x.index).
# But that doesn't work with the way that the subset iteration
Expand Down
2 changes: 1 addition & 1 deletion seaborn/_oldcore.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1116,7 +1116,7 @@ def comp_data(self):
parts = []
grouped = self.plot_data[var].groupby(self.converters[var], sort=False)
for converter, orig in grouped:
with pd.option_context('mode.use_inf_as_null', True):
with pd.option_context('mode.use_inf_as_na', True):
orig = orig.dropna()
if var in self.var_levels:
# TODO this should happen in some centralized location
Expand Down
2 changes: 1 addition & 1 deletion seaborn/categorical.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1791,7 +1791,7 @@ def _lv_box_ends(self, vals):
vals = np.asarray(vals)
# Remove infinite values while handling a 'object' dtype
# that can come from pd.Float64Dtype() input
with pd.option_context('mode.use_inf_as_null', True):
with pd.option_context('mode.use_inf_as_na', True):
vals = vals[~pd.isnull(vals)]
n = len(vals)
p = self.outlier_prop
Expand Down