Skip to content

Use a stable algorithm in sorting marks #3064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 8, 2022
Merged

Use a stable algorithm in sorting marks #3064

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions doc/whatsnew/v0.12.1.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ v0.12.1 (Unreleased)

- |Feature| The :class:`Band` and :class:`Range` marks will now cover the full extent of the data if `min` / `max` variables are not explicitly assigned or added in a transform (:pr:`3056`).

- |Enhancement| Marks that sort along the orient axis (e.g. :class:`Line`) now use a stable algorithm (:pr:`3064`).

- |Fix| Make :class:`objects.PolyFit` robust to missing data (:pr:`3010`).

- |Fix| Fixed a bug that caused an exception when more than two layers with the same mappings were added (:pr:`3055`).
Expand Down
2 changes: 1 addition & 1 deletion seaborn/_marks/area.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ def _postprocess_artist(self, artist, ax, orient):
def _get_verts(self, data, orient):

dv = {"x": "y", "y": "x"}[orient]
data = data.sort_values(orient)
data = data.sort_values(orient, kind="mergesort")
verts = np.concatenate([
data[[orient, f"{dv}min"]].to_numpy(),
data[[orient, f"{dv}max"]].to_numpy()[::-1],
Expand Down
4 changes: 2 additions & 2 deletions seaborn/_marks/line.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ def _plot(self, split_gen, scales, orient):
vals["marker"] = vals["marker"]._marker

if self._sort:
data = data.sort_values(orient)
data = data.sort_values(orient, kind="mergesort")

artist_kws = self.artist_kws.copy()
self._handle_capstyle(artist_kws, vals)
Expand Down Expand Up @@ -184,7 +184,7 @@ def _setup_lines(self, split_gen, scales, orient):
vals["color"] = resolve_color(self, keys, scales=scales)

if self._sort:
data = data.sort_values(orient)
data = data.sort_values(orient, kind="mergesort")

# Column stack to avoid block consolidation
xy = np.column_stack([data["x"], data["y"]])
Expand Down