Skip to content

Conversation

mwaskom
Copy link
Owner

@mwaskom mwaskom commented May 22, 2022

I'm not totally satisfied with this, but mutating the layer dict
(the other option) doesn't seem much cleaner.

The result is proper behavior here:

so.Plot(tips, y="total_bill").add(so.Bar(), so.Hist())

image

I'm not totally satisfied with this, but mutating the layer dict
(the other option) doesn't seem much cleaner.
@mwaskom mwaskom added this to the v0.12.0 milestone May 22, 2022
@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #2818 (7dedde5) into master (651d06e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2818   +/-   ##
=======================================
  Coverage   97.96%   97.96%           
=======================================
  Files          67       67           
  Lines       21789    21800   +11     
=======================================
+ Hits        21345    21356   +11     
  Misses        444      444           
Impacted Files Coverage Δ
seaborn/_core/plot.py 95.13% <100.00%> (+0.02%) ⬆️
seaborn/_marks/base.py 96.72% <100.00%> (ø)
seaborn/tests/_core/test_plot.py 98.38% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 651d06e...7dedde5. Read the comment docs.

@mwaskom mwaskom merged commit 7d1c50f into master May 23, 2022
@mwaskom mwaskom deleted the fix/single_var_orient branch May 23, 2022 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant