Fix size norm extrapolation #2580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2580 +/- ##
==========================================
+ Coverage 97.27% 97.44% +0.17%
==========================================
Files 17 17
Lines 6340 6351 +11
==========================================
+ Hits 6167 6189 +22
+ Misses 173 162 -11
Continue to review full report at Codecov.
|
This was referenced May 10, 2021
|
|
mwaskom
added a commit
that referenced
this pull request
Aug 6, 2021
* fix size range * add default value to sizes * Add test for GH2539 * Restrict usage of default size range attribute * Work around archaic matplotlib auto-legending of named Series objects Co-authored-by: Risako <[email protected]> (cherry picked from commit 405f666)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #2579 with
size_rangeattribute on theSizeMappingobject, rather than accessing the_default_size_rangeattribute, which is regrettable and will ideally get refactored away somehow.