Several fixes/improvements related to lmplot axis scaling #2576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2576 +/- ##
==========================================
+ Coverage 97.27% 97.46% +0.19%
==========================================
Files 17 17
Lines 6340 6354 +14
==========================================
+ Hits 6167 6193 +26
+ Misses 173 161 -12
Continue to review full report at Codecov.
|
mwaskom
added a commit
that referenced
this pull request
Aug 6, 2021
* Only set sticky edges on regression line when not truncating * Improve how datalimits are established for non-truncated lines Fixes #2509 * Add facet_kws to lmplot Closes #2518 * Update release notes * Skip test that fails because of matplotlib bug xref matplotlib/matplotlib#15967 * Always set datalims using float data * Deprecate sharex/sharey/legend_out from lmplot signature * Tweak release note [skip ci] (cherry picked from commit 3750373)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rolls together a couple small fixes to semi-related issues in
lmplot.Fixes sticky edges on regression line with
truncate=TrueI don't actually think there's an issue about this, but it's ugly and not intentional:
Old:
New:
Fixes
shareywith very different scalesThis improves the code that scales the x axis to the data limits before plotting so that it does not interfere with
sharey=False(fixes #2509)Using the example case from that issue:
Adds
facet_kwstolmplotand deprecate a couple params from the signatureFixes #2518.
Additionally,
sharex/sharey/legend_outhave been deprecated from thelmplotsignature, but they can now be passed using this parameter dictionary.