Skip to content

Conversation

lmcinnes
Copy link

@lmcinnes lmcinnes commented Dec 3, 2018

Following some of the discussion from #1536, here is a strawman API for adding ECDF plotting -- essentially it would be an extra option of what you view is a distplot. I've tried to hew as closely to the existing API for such things, but would be happy to discuss. I am sure you are currently very busy, and I have no expectations for this PR; I merely wanted to provide a basic strawman in case you were interested.

@mwaskom
Copy link
Owner

mwaskom commented Dec 3, 2018

Thanks — as you suspect I don't have time to think through all the relevant issues right now, but this looks very good foundation to build from.

@mwaskom mwaskom mentioned this pull request Jun 15, 2020
5 tasks
@mwaskom
Copy link
Owner

mwaskom commented Jun 15, 2020

Thanks for kicking this off a while back.

I've now implemented it in #2141. As the distributions module has been completely revamped in the meantime, it was not possible to pull these commits into the history. But please weight in on #2141 if you have any thoughts on the features or implementation.

@mwaskom mwaskom closed this Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants