partially resolve strict TypeScript config issues (many still remaining) #1183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ronalduQualabs is attempting to deploy a commit to the Mux Team on Vercel. A member of the Team first needs to authorize it. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1183 +/- ##
==========================================
- Coverage 78.55% 75.28% -3.28%
==========================================
Files 59 54 -5
Lines 11080 13132 +2052
Branches 0 765 +765
==========================================
+ Hits 8704 9886 +1182
- Misses 2376 3216 +840
- Partials 0 30 +30 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pintorado
reviewed
Aug 19, 2025
Pintorado
reviewed
Aug 19, 2025
Pintorado
reviewed
Aug 19, 2025
Pintorado
reviewed
Aug 19, 2025
Comment on lines
+47
to
+49
| const controller = getMediaController(this); | ||
| if (!controller) return null; | ||
| return controller.querySelector('media-settings-menu') as HTMLElement | null; |
There was a problem hiding this comment.
Same for this, could be done as in the media-rendition-menu-button
Pintorado
reviewed
Aug 19, 2025
Pintorado
reviewed
Aug 19, 2025
Pintorado
reviewed
Aug 19, 2025
Pintorado
reviewed
Aug 20, 2025
src/js/media-preview-thumbnail.ts
Outdated
Comment on lines
1
to
2
| import { MediaUIAttributes } from './constants.js'; | ||
| import { MediaStateReceiverAttributes } from './constants.js'; |
There was a problem hiding this comment.
Suggested change
| import { MediaUIAttributes } from './constants.js'; | |
| import { MediaStateReceiverAttributes } from './constants.js'; | |
| import { | |
| MediaUIAttributes, | |
| MediaStateReceiverAttributes, | |
| } from './constants.js'; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses several of the type errors surfaced when enabling TypeScript's
strictconfiguration, moving the project closer to fullstrictcompliance.There are still a number of type violations remaining.