Implement the pass through #172
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@glaslos could you please have a check? |
glaslos
requested changes
Feb 15, 2025
glaslos
requested changes
Mar 9, 2025
glutton.go
Outdated
| @@ -216,6 +216,7 @@ func (g *Glutton) tcpListen() { | |||
| } | |||
|
|
|||
| md, err := g.connTable.RegisterConn(conn, rule) | |||
|
|
|||
| @@ -29,6 +29,9 @@ rules: | |||
| - match: tcp dst port 11211 | |||
| type: conn_handler | |||
| target: memcache | |||
| - match: tcp dst port 8080 | |||
| type: pass_through | |||
| target: pass_through | |||
There was a problem hiding this comment.
We can use a host:port as a target here
protocols/protocols.go
Outdated
| @@ -3,6 +3,7 @@ package protocols | |||
| import ( | |||
| "bytes" | |||
| "context" | |||
| "github.com/mushorg/glutton/rules" | |||
Comment on lines
+41
to
+44
| go func() { | ||
| _, err := io.Copy(targetConn, conn) | ||
| errChan <- err | ||
| }() |
|
Please resolve the merge conflicts. |
|
@jerryyummy are you still planning to work on this issue? |
sorry about that, i can not solve it right now, but i will solve it if i have the time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #161 implement passthrough so when you try to access a specific port, it will not set a handler for this port, and it just pass traffic to the target server not glutton