[From MU3 backend] Eng-35: MusicXML import Small Notes vs. Small Chord #9506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since MusicXML only stores note-level information about smallness (<type size='cue'> and <cue>), chords that should be small were being read as normal-sized chords of small notes. This caused issues with the sizes of flags, ledger lines, and articulations. This commit adds handleSmallness to ensure that a chord with all small notes is imported as a small chord with all non-small notes, as well as a test for this particular case.
|
I'm going to close all of these forward-ports because a lot of them deal with the same files, so it makes sense to combine them in a more intelligent way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from #8181