Fix https://musescore.org/en/node/324626 - linked dynamics not saving

[wizofaus]

Resolves: https://musescore.org/en/node/324626

Dynamics not correctly updated when they had linked elements in other parts (in fact even for unlinked dynamics, the dynamicType wasn't getting set as expected if the new text was a valid dynamic)

• I signed CLA
• I made sure the code in the PR follows the coding rules
• I made sure the code compiles on my machine
• I made sure there are no unnecessary changes in the code
• I made sure the title of the PR reflects the core meaning of the issue you are solving
• I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
• I made sure the commit message title starts with "fix #424242:" if there is a related issue
• I created the test (mtest, vtest, script test) to verify the changes I made

[HowardC2019]

The commit message should have "fix #324626" instead of the whole link if you want the issue to be automatically closed when this PR is merged.

[wizofaus]

Then how does it distinguish between github issues and MuseScore.org issues??

[HowardC2019]

It's easy since GitHub issues are four digits whereas MuseScore issues are most likely six digits. You can write "fix GH#" if you're fixing GitHub issues, that format doesn't matter.

[Jojo-Schmitz]

Then how does it distinguish between github issues and MuseScore.org issues??

It does not. Github Issues are best referred to in the inital comment (for PRs against master).

[Jojo-Schmitz]

Any reason not to merge this one?

[wizofaus]

Not that I'm aware of, I guess it just isn't considered a priority at this point.

[mike-spa]

The original issued is now fixed in version 4.1 as part of the more general work on dynamics.