horizontal fixed layout added (each measure has the same size) #9068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

igorkorsukov merged 1 commit into musescore:master from alexpavlov96:horizontal_fixed_layout

Sep 9, 2021

Contributor

alexpavlov96 commented Sep 8, 2021

Resolves: (direct link to the issue)

(short description of the changes and the motivation to make the changes)

I signed CLA
I made sure the code in the PR follows the coding rules
I made sure the code compiles on my machine
I made sure there are no unnecessary changes in the code
I made sure the title of the PR reflects the core meaning of the issue you are solving
I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
I made sure the commit message title starts with "fix #424242:" if there is a related issue
I created the test (mtest, vtest, script test) to verify the changes I made

Contributor

Jojo-Schmitz commented Sep 8, 2021 •

edited

Loading

Seems this would fix a pretty frequent request, see https://musescore.org/en/node/313555.
If so maybe change the commit title to start with "Fix #313555: "?

Isn't there any UI to switch this on/off?

Jojo-Schmitz reviewed

View reviewed changes

src/engraving/libmscore/measure.cpp

    
              {

                  Segment* current = nullptr;

                  for (current = measure->first(); current && !current->enabled(); current = current->next()) {

                  }

Contributor

Jojo-Schmitz Sep 8, 2021

Empty for loop?

Contributor Author

alexpavlov96 Sep 8, 2021

it chanegs the current segment

Contributor

Jojo-Schmitz Sep 8, 2021

Yes, I see that it used the side effect, but that's confusing code, to me at least.

Contributor

igorkorsukov Sep 8, 2021 •

edited

Loading

I agree with Jojo, I believe needs rewrite this code

Contributor

Jojo-Schmitz Sep 9, 2021

yes, that while loop is better

Contributor Author

alexpavlov96 commented Sep 8, 2021 •

edited

Loading

Seems this would fix a pretty frequent request, see https://musescore.org/en/node/313555.
If so maybe change the commit title to start with "Fix #313555: "?

Isn't there any UI to switch this on/off?

@Jojo-Schmitz there is no UI. I didn't know about the issue. I tested with setting in layoutoptions.h:

struct LayoutOptions
{
LayoutMode mode = LayoutMode::HORIZONTAL_FIXED;

Contributor

Jojo-Schmitz commented Sep 8, 2021 •

edited

Loading

OK, so a UI for this is not part of this PR (yet), but needed.
At least an advanced preference setting.

igorkorsukov reviewed

View reviewed changes

src/engraving/libmscore/masterscore.h Outdated

    
                  QSet<int> occupiedMidiChannels;                   // each entry is port*16+channel, port range: 0-inf, channel: 0-15

                  unsigned int searchMidiMappingFrom = 0;           // makes getting next free MIDI mapping faster

                  qreal m_widthOfSegmentCell { 3 };

Contributor

igorkorsukov Sep 8, 2021

needs qreal m_widthOfSegmentCell = 3.0;(https://github.com/musescore/MuseScore/wiki/CodeGuidelines#declaring-variables)

igorkorsukov reviewed

View reviewed changes

src/engraving/libmscore/measure.cpp Outdated

    
              qreal Measure::computeFirstSegmentXPosition(Segment* segment)

              {

                  qreal x{ 0 };

Contributor

igorkorsukov Sep 8, 2021

needs qreal x = 0.0;
https://github.com/musescore/MuseScore/wiki/CodeGuidelines#declaring-variables


          horizontal fixed layout added (each measure has the same size)

alexpavlov96 force-pushed the horizontal_fixed_layout branch from f33158d to 2221851 Compare

September 9, 2021 09:50

Contributor Author

alexpavlov96 commented Sep 9, 2021

OK, so a UI for this is not part of this PR (yet), but needed.
At least an advanced preference setting.

@Jojo-Schmitz, no UI yet, so I didn't change the name

Contributor

igorkorsukov commented Sep 9, 2021

We plan to make the UI later

igorkorsukov merged commit 392cca9 into musescore:master

This was referenced Sep 9, 2021

[MU3] Fix GH#7449: Almost everything suitable for 3.6.3 or 3.7.0 #9000

Closed

[MU3 Issue] MuseScore 3.6.3 or 3.7.0, PRs to be merged and issues to be fixed. #7449

Closed

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Bare min. from PR#9068 to be able to port PR#9137 to 3.x

57bb3af

(Very partial) backport of musescore#9068

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Bare min. from PR#9068 to be able to port PR#9137 to 3.x

3c4f200

(Very partial) backport of musescore#9068, the rest is too large for too litle
benefit (mainly due to the missing UI) and also requires C++17.

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Bare min. from PR#9068 to be able to port PR#9137 to 3.x

001f87d

(Very partial) backport of musescore#9068, the rest is too large for too litle
benefit (mainly due to the missing UI) and also requires C++17.

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Bare min. from PR#9068 to be able to port PR#9137 to 3.x

c823c8f

(Very partial) backport of musescore#9068, the rest is too large for too litle
benefit (mainly due to the missing UI) and also requires C++17.

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix GH#9007 - Invisible key/time signatures having adverse effect on …

254ca44

…spacing

Backport of musescore#9137 (needs parts of musescore#9068)

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Bare min. from PR#9068 to be able to port PR#9137 to 3.x

a75bd6f

(Very partial) backport of musescore#9068, the rest is too large for too litle
benefit (mainly due to the missing UI) and also requires C++17.

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix GH#9007 - Invisible key/time signatures having adverse effect on …

32b9364

…spacing

Backport of musescore#9137 (needs parts of musescore#9068)

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Bare min. from PR#9068 to be able to port PR#9137 to 3.x

6f8342c

(Very partial) backport of musescore#9068, the rest is too large for too litle
benefit (mainly due to the missing UI) and also requires C++17.

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix GH#9007 - Invisible key/time signatures having adverse effect on …

7eaf39f

…spacing

Backport of musescore#9137 (needs parts of musescore#9068)

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Bare min. from PR#9068 to be able to port PR#9137 to 3.x

9284edc

(Very partial) backport of musescore#9068, the rest is too large for too litle
benefit (mainly due to the missing UI) and also requires C++17.

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix GH#9007 - Invisible key/time signatures having adverse effect on …

0b338b4

…spacing

Backport of musescore#9137 (needs parts of musescore#9068)

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Bare min. from PR#9068 to be able to port PR#9137 to 3.x

96687aa

(Very partial) backport of musescore#9068, the rest is too large for too litle
benefit (mainly due to the missing UI) and also requires C++17.

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix GH#9007 - Invisible key/time signatures having adverse effect on …

0260fc0

…spacing

Backport of musescore#9137 (needs parts of musescore#9068)

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Bare min. from PR#9068 to be able to port PR#9137 to 3.x

6bb3537

(Very partial) backport of musescore#9068, the rest is too large for too litle
benefit (mainly due to the missing UI) and also requires C++17.

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix GH#9007 - Invisible key/time signatures having adverse effect on …

c6c8081

…spacing

Backport of musescore#9137 (needs parts of musescore#9068)

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Bare min. from PR#9068 to be able to port PR#9137 to 3.x

ae84f88

(Very partial) backport of musescore#9068, the rest is too large for too litle
benefit (mainly due to the missing UI) and also requires C++17.

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix GH#9007 - Invisible key/time signatures having adverse effect on …

7ca6a7d

…spacing

Backport of musescore#9137 (needs parts of musescore#9068)

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Bare min. from PR#9068 to be able to port PR#9137 to 3.x

314a7fe

(Very partial) backport of musescore#9068, the rest is too large for too litle
benefit (mainly due to the missing UI) and also requires C++17.

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix GH#9007 - Invisible key/time signatures having adverse effect on …

fe862fd

…spacing

Backport of musescore#9137 (needs parts of musescore#9068)

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Bare min. from PR#9068 to be able to port PR#9137 to 3.x

794b109

(Very partial) backport of musescore#9068, the rest is too large for too litle
benefit (mainly due to the missing UI) and also requires C++17.

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix GH#9007 - Invisible key/time signatures having adverse effect on …

98758f4

…spacing

Backport of musescore#9137 (needs parts of musescore#9068)

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Bare min. from musescore#9068 to be able to port musescore#9137 to 3.x

065d897

(Very partial) backport of musescore#9068, the rest is too large for too litle
benefit (mainly due to the missing UI) and also requires C++17.

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix GH#9007: Invisible key/time signatures having adverse effect on s…

18284d2

…pacing

Backport of musescore#9137 (needs parts of musescore#9068)

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Bare min. from musescore#9068 to be able to port musescore#9137 to 3.x

597528e

(Very partial) backport of musescore#9068, the rest is too large for too litle
benefit (mainly due to the missing UI) and also requires C++17.

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix GH#9007: Invisible key/time signatures having adverse effect on s…

db78b34

…pacing

Backport of musescore#9137 (needs parts of musescore#9068)

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Bare min. from musescore#9068 to be able to port musescore#9137 to 3.x

6dacd43

(Very partial) backport of musescore#9068, the rest is too large for too litle
benefit (mainly due to the missing UI) and also requires C++17.

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix GH#9007: Invisible key/time signatures having adverse effect on s…

c285c40

…pacing

Backport of musescore#9137 (needs parts of musescore#9068)

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Bare min. from musescore#9068 to be able to port musescore#9137 to 3.x

75ae1c6

(Very partial) backport of musescore#9068, the rest is too large for too litle
benefit (mainly due to the missing UI) and also requires C++17.

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix GH#9007: Invisible key/time signatures having adverse effect on s…

2f3a274

…pacing

Backport of musescore#9137 (needs parts of musescore#9068)

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Bare min. from musescore#9068 to be able to port musescore#9137 to 3.x

9416d18

(Very partial) backport of musescore#9068, the rest is too large for too litle
benefit (mainly due to the missing UI) and also requires C++17.

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix GH#9007: Invisible key/time signatures having adverse effect on s…

f0df368

…pacing

Backport of musescore#9137 (needs parts of musescore#9068)

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Bare min. from musescore#9068 to be able to port musescore#9137 to 3.x

651db55

(Very partial) backport of musescore#9068, the rest is too large for too litle
benefit (mainly due to the missing UI) and also requires C++17.

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix GH#9007: Invisible key/time signatures having adverse effect on s…

753efe4

…pacing

Backport of musescore#9137 (needs parts of musescore#9068)

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Bare min. from musescore#9068 to be able to port musescore#9137 to 3.x

18712e4

(Very partial) backport of musescore#9068, the rest is too large for too litle
benefit (mainly due to the missing UI) and also requires C++17.

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix GH#9007: Invisible key/time signatures having adverse effect on s…

ca02207

…pacing

Backport of musescore#9137 (needs parts of musescore#9068)

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Bare min. from musescore#9068 to be able to port musescore#9137 to 3.x

50c8585

(Very partial) backport of musescore#9068, the rest is too large for too litle
benefit (mainly due to the missing UI) and also requires C++17.

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix GH#9007: Invisible key/time signatures having adverse effect on s…

5b4f15e

…pacing

Backport of musescore#9137 (needs parts of musescore#9068)

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Bare min. from musescore#9068 to be able to port musescore#9137 to 3.x

fa01325

(Very partial) backport of musescore#9068, the rest is too large for too litle
benefit (mainly due to the missing UI) and also requires C++17.

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix GH#9007: Invisible key/time signatures having adverse effect on s…

caed917

…pacing

Backport of musescore#9137 (needs parts of musescore#9068)

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Bare min. from musescore#9068 to be able to port musescore#9137 to 3.x

381fc3a

(Very partial) backport of musescore#9068, the rest is too large for too litle
benefit (mainly due to the missing UI) and also requires C++17.

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix GH#9007: Invisible key/time signatures having adverse effect on s…

3537b15

…pacing

Backport of musescore#9137 (needs parts of musescore#9068)

Jojo-Schmitz mentioned this pull request

Fix GH#7449: Almost everything suitable for 3.6.3 or 3.7.0 Jojo-Schmitz/MuseScore#80

Closed

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Bare min. from musescore#9068 to be able to port musescore#9137 to 3.x

c4e7259

(Very partial) backport of musescore#9068, the rest is too large for too litle
benefit (mainly due to the missing UI) and also requires C++17.

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request


          Fix GH#9007: Invisible key/time signatures having adverse effect on s…

34ed205

…pacing

Backport of musescore#9137 (needs parts of musescore#9068)

alexpavlov96 deleted the horizontal_fixed_layout branch

June 26, 2023 13:58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet