Skip to content

Conversation

@lyrra
Copy link
Contributor

@lyrra lyrra commented Sep 3, 2021

Resolves: https://musescore.org/en/node/274126

Tiny fix, that enables different note-value entered from midi, on top of an slur.

  • [x ] I signed CLA

Perhaps too late for 3.6.3, on the other hand, a very conservative change.

@lyrra lyrra changed the title [MU3] Fix #274126 Crash when midi-entering on top of an unterminated slur [MU3] Fix #274126 Crash when entering music on top of an unterminated slur by MIDI Sep 3, 2021
@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Sep 3, 2021

I guess I'll just add it to #9000 (Edit: done), but won't it apply to master too?

@lyrra
Copy link
Contributor Author

lyrra commented Sep 4, 2021

I guess I'll just add it to #9000 (Edit: done), but won't it apply to master too?
I guess it applies to master too. But I can't verify it in MU4, no audio/midi in gui.
MU3 is tested by launching two musescores and midi-connecting them in qjackctl graph.

@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Sep 4, 2021

Yes, 3.x is often still pretty usefull as a testbed. In this case though, I'd just add this to master, no real need to test, the code is very obviously correct to protect from dereferencing a nullptr

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 4, 2021
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 4, 2021
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 4, 2021
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 9, 2021
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 10, 2021
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 23, 2021
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 24, 2021
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 26, 2021
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 29, 2021
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request May 12, 2022
@RomanPudashkin
Copy link
Contributor

3.x is closed for any changes

@lyrra lyrra deleted the 20210902-fix-274126 branch December 20, 2022 15:41
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants