[MU4] Don't have strings in plugins translatable that [dw]on't work anyhow #8985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jojo-Schmitz
force-pushed
the
plugin-translations
branch
from
99bf582 to
266fb85
Compare
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 1, 2021
The plugin description and -path are not shown translated even if they are (like for the helloqml plugin and German). Showing as being translatable gives a wrong impression as examples for other plugins. Backport of musescore#8985 plus some other random findings (not relevant to the master branch)
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 1, 2021
The plugin description and -path are not shown translated even if they are (like for the helloqml plugin and German). Showing as being translatable gives a wrong impression as examples for other plugins. Backport of musescore#8985 plus some other random findings (not relevant to the master branch)
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 2, 2021
The plugin description and -path are not shown translated even if they are (like for the helloqml plugin and German). Showing as being translatable gives a wrong impression as examples for other plugins. Backport of musescore#8985 plus some other random findings (not relevant to the master branch)
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 2, 2021
The plugin description and -path are not shown translated even if they are (like for the helloqml plugin and German). Showing as being translatable gives a wrong impression as examples for other plugins. Backport of musescore#8985 plus some other random findings (not relevant to the master branch)
Jojo-Schmitz
force-pushed
the
plugin-translations
branch
2 times, most recently
from
eb673f6 to
76d0c8d
Compare
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 3, 2021
The plugin description and -path are not shown translated even if they are (like for the helloqml plugin and German). Showing as being translatable gives a wrong impression as examples for other plugins. BTW: Those descriptions do translate in the Plugin Editor/Creator's console log, but only there. While at it, make helloqml actually work, it apparently had never been ported from 2.x to 3.x (and later). Backport of musescore#8985 plus some other random findings (not relevant to the master branch)
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 9, 2021
The plugin description and -path are not shown translated even if they are (like for the helloqml plugin and German). Showing as being translatable gives a wrong impression as examples for other plugins. BTW: Those descriptions do translate in the Plugin Editor/Creator's console log, but only there. While at it, make helloqml actually work, it apparently had never been ported from 2.x to 3.x (and later). Backport of musescore#8985 plus some other random findings (not relevant to the master branch)
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 10, 2021
The plugin description and -path are not shown translated even if they are (like for the helloqml plugin and German). Showing as being translatable gives a wrong impression as examples for other plugins. BTW: Those descriptions do translate in the Plugin Editor/Creator's console log, but only there. While at it, make helloqml actually work, it apparently had never been ported from 2.x to 3.x (and later). Backport of musescore#8985 plus some other random findings (not relevant to the master branch)
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 23, 2021
The plugin description and -path are not shown translated even if they are (like for the helloqml plugin and German). Showing as being translatable gives a wrong impression as examples for other plugins. BTW: Those descriptions do translate in the Plugin Editor/Creator's console log, but only there. While at it, make helloqml actually work, it apparently had never been ported from 2.x to 3.x (and later). Backport of musescore#8985 plus some other random findings (not relevant to the master branch)
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 24, 2021
The plugin description and -path are not shown translated even if they are (like for the helloqml plugin and German). Showing as being translatable gives a wrong impression as examples for other plugins. BTW: Those descriptions do translate in the Plugin Editor/Creator's console log, but only there. While at it, make helloqml actually work, it apparently had never been ported from 2.x to 3.x (and later). Backport of musescore#8985 plus some other random findings (not relevant to the master branch)
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 26, 2021
The plugin description and -path are not shown translated even if they are (like for the helloqml plugin and German). Showing as being translatable gives a wrong impression as examples for other plugins. BTW: Those descriptions do translate in the Plugin Editor/Creator's console log, but only there. While at it, make helloqml actually work, it apparently had never been ported from 2.x to 3.x (and later). Backport of musescore#8985 plus some other random findings (not relevant to the master branch)
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 29, 2021
The plugin description and -path are not shown translated even if they are (like for the helloqml plugin and German). Showing as being translatable gives a wrong impression as examples for other plugins. BTW: Those descriptions do translate in the Plugin Editor/Creator's console log, but only there. While at it, make helloqml actually work, it apparently had never been ported from 2.x to 3.x (and later). Backport of musescore#8985 plus some other random findings (not relevant to the master branch)
Jojo-Schmitz
force-pushed
the
plugin-translations
branch
2 times, most recently
from
4903fc2 to
c6300f5
Compare
Jojo-Schmitz
force-pushed
the
plugin-translations
branch
from
c6300f5 to
d9eee19
Compare
Jojo-Schmitz
force-pushed
the
plugin-translations
branch
from
d9eee19 to
3f1915a
Compare
The plugin description and -path are not shown translated even if they are (like for the helloqml plugin and German). Showing as being translatable gives a wrong impression as examples for other plugins. BTW: Those descriptions do translate in the Plugin Editor/Creator's console log, but only there While at it, make helloqml actually work, it apparently had never been ported from 2.x to 3.x (and later)
and while at it make a few changes to it recommended by QtCreator's editor
Jojo-Schmitz
force-pushed
the
plugin-translations
branch
from
3f1915a to
1110973
Compare
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
May 12, 2022
The plugin description and -path are not shown translated even if they are (like for the helloqml plugin and German). Showing as being translatable gives a wrong impression as examples for other plugins. BTW: Those descriptions do translate in the Plugin Editor/Creator's console log, but only there. While at it, make helloqml actually work, it apparently had never been ported from 2.x to 3.x (and later). Backport of musescore#8985 plus some other random findings (not relevant to the master branch)
|
See #11866, which seems to include the removal of these (non-)translatable strings |
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Mar 5, 2023
The plugin description and -path are not shown translated even if they are (like for the helloqml plugin and German). Showing as being translatable gives a wrong impression as examples for other plugins. BTW: Those descriptions do translate in the Plugin Editor/Creator's console log, but only there. While at it, make helloqml actually work, it apparently had never been ported from 2.x to 3.x (and later). Backport of musescore#8985 plus some other random findings (not relevant to the master branch)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plugin description and -path are not shown translated even if they are (like for the helloqml plugin and German).
Showing as being translatable gives a wrong impression as examples for other plugins.
BTW: Those descriptions do translate in the Plugin Editor/Creator's console log, but only there.
While at it, make helloqml actually work, it apparently had never been ported from 2.x to 3.x (and later).
To avoid merge conflicts I've added another commit here:
Fix #325019: Fix notenames plugin when adding octaves to chords and while at it make a few changes to it recommended by QtCreator's editor
Same changes would apply to 3.x too