-
Notifications
You must be signed in to change notification settings - Fork 3k
[MU4] Fix #324232: after a MIDI export without expanding repeats, those are not played in the current session anymore either #8979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
RomanPudashkin
merged 1 commit into
musescore:master
from
Jojo-Schmitz:play-repeats-after-MIDI-export
Sep 24, 2021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21e7b80 to
8140481
Compare
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 31, 2021
… not played in the current session anymore either Backport of musescore#8979
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 1, 2021
… not played in the current session anymore either Backport of musescore#8979
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 2, 2021
… not played in the current session anymore either Backport of musescore#8979
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 2, 2021
… not played in the current session anymore either Backport of musescore#8979
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 9, 2021
… not played in the current session anymore either Backport of musescore#8979
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 10, 2021
… not played in the current session anymore either Backport of musescore#8979
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 23, 2021
… not played in the current session anymore either Backport of musescore#8979
8140481 to
6cfaa4b
Compare
6cfaa4b to
b5b8533
Compare
… not played in the current session anymore either
b5b8533 to
4c5190a
Compare
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 24, 2021
… not played in the current session anymore either Backport of musescore#8979
RomanPudashkin
approved these changes
Sep 24, 2021
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 26, 2021
… not played in the current session anymore either Backport of musescore#8979
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 29, 2021
… not played in the current session anymore either Backport of musescore#8979
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
May 12, 2022
… not played in the current session anymore either Backport of musescore#8979
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Mar 5, 2023
… not played in the current session anymore either Backport of musescore#8979
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://musescore.org/de/node/324232
To reproduce: Have "Play Repeats" enabled, export a score to MIDI, disable "Expand repeats", then play the still open score: it won't repeat, but the Play Repeats button is still active.
Very same fix would apply to 3.x too