-
Notifications
You must be signed in to change notification settings - Fork 3k
fix #8935 - Slurs, ties, lines extend beyond final barline #8953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #8935 - Slurs, ties, lines extend beyond final barline #8953
Conversation
similar to firstNoteRestSegmentX(bool)
replaced bbox() stuff with new lastNoteRestSegmentX function
|
The gliss line remains a problem here (though the tie is spot on): |
similar to firstNoteRestSegmentX(bool) Backport of musescore#8953, part 1
replaced bbox() stuff with new lastNoteRestSegmentX function Backport of musescore#8953, part 2
|
Looks good to me. If you mean that the lines could end later if they are in no danger of colliding with the dots, I feel it is better that they all end at a consistent point by default. Otherwise one could end up with a situation like this: Also, the dots are clearer if they do not become enclosed by other symbols. |
Backport of musescore#8953, part 3
similar to firstNoteRestSegmentX(bool) Backport of musescore#8953, part 1
replaced bbox() stuff with new lastNoteRestSegmentX function Backport of musescore#8953, part 2
Backport of musescore#8953, part 3
similar to firstNoteRestSegmentX(bool) Backport of musescore#8953, part 1
replaced bbox() stuff with new lastNoteRestSegmentX function Backport of musescore#8953, part 2
Backport of musescore#8953, part 3
similar to firstNoteRestSegmentX(bool) Backport of musescore#8953, part 1
replaced bbox() stuff with new lastNoteRestSegmentX function Backport of musescore#8953, part 2
Backport of musescore#8953, part 3
similar to firstNoteRestSegmentX(bool) Backport of musescore#8953, part 1
replaced bbox() stuff with new lastNoteRestSegmentX function Backport of musescore#8953, part 2
Backport of musescore#8953, part 3
|
Why is this not getting merged? |
similar to firstNoteRestSegmentX(bool) Backport of musescore#8953, part 1
replaced bbox() stuff with new lastNoteRestSegmentX function Backport of musescore#8953, part 2
Backport of musescore#8953, part 3
similar to firstNoteRestSegmentX(bool) Backport of musescore#8953, part 1
replaced bbox() stuff with new lastNoteRestSegmentX function Backport of musescore#8953, part 2
Backport of musescore#8953, part 3
similar to firstNoteRestSegmentX(bool) Backport of musescore#8953, part 1
replaced bbox() stuff with new lastNoteRestSegmentX function Backport of musescore#8953, part 2
Backport of musescore#8953, part 3
similar to firstNoteRestSegmentX(bool) Backport of musescore#8953, part 1
replaced bbox() stuff with new lastNoteRestSegmentX function Backport of musescore#8953, part 2
Backport of musescore#8953, part 3
similar to firstNoteRestSegmentX(bool) Backport of musescore#8953, part 1
replaced bbox() stuff with new lastNoteRestSegmentX function Backport of musescore#8953, part 2
Backport of musescore#8953, part 3
similar to firstNoteRestSegmentX(bool) Backport of musescore#8953, part 1
replaced bbox() stuff with new lastNoteRestSegmentX function Backport of musescore#8953, part 2
Backport of musescore#8953, part 3



Resolves: #8935
The margin before the final barline is hardcoded for now, but it is only in one place, so it's very simple to refactor later if it becomes a user-facing parameter. For now, it is 0.25sp.