Skip to content

Conversation

@asattely
Copy link
Contributor

Resolves: #8935

The margin before the final barline is hardcoded for now, but it is only in one place, so it's very simple to refactor later if it becomes a user-facing parameter. For now, it is 0.25sp.

similar to firstNoteRestSegmentX(bool)
replaced bbox() stuff with new lastNoteRestSegmentX function
@its-not-nice
Copy link
Contributor

The gliss line remains a problem here (though the tie is spot on):
gliss-frame
This sample file at: https://musescore.org/en/node/319761

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 30, 2021
similar to firstNoteRestSegmentX(bool)

Backport of musescore#8953, part 1
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 30, 2021
replaced bbox() stuff with new lastNoteRestSegmentX function

Backport of musescore#8953, part 2
@Jojo-Schmitz
Copy link
Contributor

What about non-normal barlines, most notably end repeat? Now looks like this:
image

@its-not-nice
Copy link
Contributor

its-not-nice commented Aug 30, 2021

Looks good to me. If you mean that the lines could end later if they are in no danger of colliding with the dots, I feel it is better that they all end at a consistent point by default. Otherwise one could end up with a situation like this:

urgh

Also, the dots are clearer if they do not become enclosed by other symbols.

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 31, 2021
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 1, 2021
similar to firstNoteRestSegmentX(bool)

Backport of musescore#8953, part 1
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 1, 2021
replaced bbox() stuff with new lastNoteRestSegmentX function

Backport of musescore#8953, part 2
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 1, 2021
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 2, 2021
similar to firstNoteRestSegmentX(bool)

Backport of musescore#8953, part 1
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 2, 2021
replaced bbox() stuff with new lastNoteRestSegmentX function

Backport of musescore#8953, part 2
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 2, 2021
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 2, 2021
similar to firstNoteRestSegmentX(bool)

Backport of musescore#8953, part 1
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 2, 2021
replaced bbox() stuff with new lastNoteRestSegmentX function

Backport of musescore#8953, part 2
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 2, 2021
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 9, 2021
similar to firstNoteRestSegmentX(bool)

Backport of musescore#8953, part 1
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 9, 2021
replaced bbox() stuff with new lastNoteRestSegmentX function

Backport of musescore#8953, part 2
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 9, 2021
@Jojo-Schmitz
Copy link
Contributor

Why is this not getting merged?

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 10, 2021
similar to firstNoteRestSegmentX(bool)

Backport of musescore#8953, part 1
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 10, 2021
replaced bbox() stuff with new lastNoteRestSegmentX function

Backport of musescore#8953, part 2
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 10, 2021
@RomanPudashkin RomanPudashkin merged commit 4f2c437 into musescore:master Sep 14, 2021
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 23, 2021
similar to firstNoteRestSegmentX(bool)

Backport of musescore#8953, part 1
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 23, 2021
replaced bbox() stuff with new lastNoteRestSegmentX function

Backport of musescore#8953, part 2
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 23, 2021
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 26, 2021
similar to firstNoteRestSegmentX(bool)

Backport of musescore#8953, part 1
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 26, 2021
replaced bbox() stuff with new lastNoteRestSegmentX function

Backport of musescore#8953, part 2
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 26, 2021
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 29, 2021
similar to firstNoteRestSegmentX(bool)

Backport of musescore#8953, part 1
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 29, 2021
replaced bbox() stuff with new lastNoteRestSegmentX function

Backport of musescore#8953, part 2
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 29, 2021
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request May 12, 2022
similar to firstNoteRestSegmentX(bool)

Backport of musescore#8953, part 1
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request May 12, 2022
replaced bbox() stuff with new lastNoteRestSegmentX function

Backport of musescore#8953, part 2
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request May 12, 2022
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Mar 5, 2023
similar to firstNoteRestSegmentX(bool)

Backport of musescore#8953, part 1
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Mar 5, 2023
replaced bbox() stuff with new lastNoteRestSegmentX function

Backport of musescore#8953, part 2
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[MU4 Issue] Slurs, ties, lines extend beyond final barline

4 participants