Skip to content

[MU3 Backend] ENG-31 Coda and Segno symbol sizing manual override #8583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 9, 2021
Merged

[MU3 Backend] ENG-31 Coda and Segno symbol sizing manual override #8583

merged 1 commit into from
Aug 9, 2021

Conversation

@iveshenry18
Copy link
Contributor

Resolves: ENG-31: Correct handling of Coda symbols (sizing issue follow-up)

The sizing of REPEAT_LEFT and REPEAT_RIGHT text is inconsistent due to
the inconsistent sizing of the coda and segno symbols. This commit adds
an override on MusicXML import based on the presence of non-symbol text
as a temporary fixup for this sizing inconsistency

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Jul 9, 2021
Closed
@iveshenry18 iveshenry18 changed the title Coda and Segno symbol sizing manual override [MU3 Backend] Coda and Segno symbol sizing manual override Jul 9, 2021
@iveshenry18
Coda and Segno symbol sizing manual override
3034b81 
The sizing of REPEAT_LEFT and REPEAT_RIGHT text is inconsistent due to
the inconsistent sizing of the coda and segno symbols. This commit adds
an override on MusicXML import based on the presence of non-symbol text.
@iveshenry18 iveshenry18 force-pushed the ENG-31-coda-symbols branch from d76275a to 3034b81 Compare July 28, 2021 20:43
@iveshenry18 iveshenry18 changed the title [MU3 Backend] Coda and Segno symbol sizing manual override [MU3 Backend] ENG-31 Coda and Segno symbol sizing manual override Aug 3, 2021
@vpereverzev vpereverzev merged commit ff250cf into musescore:3.6.2_backend Aug 9, 2021
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 9, 2021
@iveshenry18 @Jojo-Schmitz
Coda and Segno symbol sizing manual override
ce47310 
The sizing of REPEAT_LEFT and REPEAT_RIGHT text is inconsistent due to
the inconsistent sizing of the coda and segno symbols. This commit adds
an override on MusicXML import based on the presence of non-symbol text.

Dulicate of musescore#8583
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 10, 2021
@iveshenry18 @Jojo-Schmitz
Coda and Segno symbol sizing manual override
5023690 
The sizing of REPEAT_LEFT and REPEAT_RIGHT text is inconsistent due to
the inconsistent sizing of the coda and segno symbols. This commit adds
an override on MusicXML import based on the presence of non-symbol text.

Dulicate of musescore#8583
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 13, 2021
@iveshenry18 @Jojo-Schmitz
Coda and Segno symbol sizing manual override
d2a3cbb 
The sizing of REPEAT_LEFT and REPEAT_RIGHT text is inconsistent due to
the inconsistent sizing of the coda and segno symbols. This commit adds
an override on MusicXML import based on the presence of non-symbol text.

Dulicate of musescore#8583
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 13, 2021
@iveshenry18 @Jojo-Schmitz
Coda and Segno symbol sizing manual override
b13707f 
The sizing of REPEAT_LEFT and REPEAT_RIGHT text is inconsistent due to
the inconsistent sizing of the coda and segno symbols. This commit adds
an override on MusicXML import based on the presence of non-symbol text.

Dulicate of musescore#8583
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 19, 2021
@iveshenry18 @Jojo-Schmitz
Coda and Segno symbol sizing manual override
0f52078 
The sizing of REPEAT_LEFT and REPEAT_RIGHT text is inconsistent due to
the inconsistent sizing of the coda and segno symbols. This commit adds
an override on MusicXML import based on the presence of non-symbol text.

Dulicate of musescore#8583
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 19, 2021
@iveshenry18 @Jojo-Schmitz
Coda and Segno symbol sizing manual override
e80951a 
The sizing of REPEAT_LEFT and REPEAT_RIGHT text is inconsistent due to
the inconsistent sizing of the coda and segno symbols. This commit adds
an override on MusicXML import based on the presence of non-symbol text.

Dulicate of musescore#8583
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 30, 2021
@iveshenry18 @Jojo-Schmitz
Coda and Segno symbol sizing manual override
3deff33 
The sizing of REPEAT_LEFT and REPEAT_RIGHT text is inconsistent due to
the inconsistent sizing of the coda and segno symbols. This commit adds
an override on MusicXML import based on the presence of non-symbol text.

Dulicate of musescore#8583
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Sep 1, 2021
Closed
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 1, 2021
@iveshenry18 @Jojo-Schmitz
Coda and Segno symbol sizing manual override
bcdd782 
The sizing of REPEAT_LEFT and REPEAT_RIGHT text is inconsistent due to
the inconsistent sizing of the coda and segno symbols. This commit adds
an override on MusicXML import based on the presence of non-symbol text.

Dulicate of musescore#8583
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 2, 2021
@iveshenry18 @Jojo-Schmitz
Coda and Segno symbol sizing manual override
44c3b6d 
The sizing of REPEAT_LEFT and REPEAT_RIGHT text is inconsistent due to
the inconsistent sizing of the coda and segno symbols. This commit adds
an override on MusicXML import based on the presence of non-symbol text.

Duplicate of musescore#8583
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 9, 2021
@iveshenry18 @Jojo-Schmitz
Coda and Segno symbol sizing manual override
0d9e6ac 
The sizing of REPEAT_LEFT and REPEAT_RIGHT text is inconsistent due to
the inconsistent sizing of the coda and segno symbols. This commit adds
an override on MusicXML import based on the presence of non-symbol text.

Duplicate of musescore#8583
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 10, 2021
@iveshenry18 @Jojo-Schmitz
Coda and Segno symbol sizing manual override
dbbe137 
The sizing of REPEAT_LEFT and REPEAT_RIGHT text is inconsistent due to
the inconsistent sizing of the coda and segno symbols. This commit adds
an override on MusicXML import based on the presence of non-symbol text.

Duplicate of musescore#8583
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 23, 2021
@iveshenry18 @Jojo-Schmitz
Coda and Segno symbol sizing manual override
1c46461 
The sizing of REPEAT_LEFT and REPEAT_RIGHT text is inconsistent due to
the inconsistent sizing of the coda and segno symbols. This commit adds
an override on MusicXML import based on the presence of non-symbol text.

Duplicate of musescore#8583
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 26, 2021
@iveshenry18 @Jojo-Schmitz
Coda and Segno symbol sizing manual override
105c520 
The sizing of REPEAT_LEFT and REPEAT_RIGHT text is inconsistent due to
the inconsistent sizing of the coda and segno symbols. This commit adds
an override on MusicXML import based on the presence of non-symbol text.

Duplicate of musescore#8583
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 29, 2021
@iveshenry18 @Jojo-Schmitz
Coda and Segno symbol sizing manual override
2a45b0d 
The sizing of REPEAT_LEFT and REPEAT_RIGHT text is inconsistent due to
the inconsistent sizing of the coda and segno symbols. This commit adds
an override on MusicXML import based on the presence of non-symbol text.

Duplicate of musescore#8583
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request May 12, 2022
@iveshenry18 @Jojo-Schmitz
Coda and Segno symbol sizing manual override
4b4e1eb 
The sizing of REPEAT_LEFT and REPEAT_RIGHT text is inconsistent due to
the inconsistent sizing of the coda and segno symbols. This commit adds
an override on MusicXML import based on the presence of non-symbol text.

Duplicate of musescore#8583
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Mar 1, 2023
Closed
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Mar 5, 2023
@iveshenry18 @Jojo-Schmitz
Coda and Segno symbol sizing manual override
91eb53d 
The sizing of REPEAT_LEFT and REPEAT_RIGHT text is inconsistent due to
the inconsistent sizing of the coda and segno symbols. This commit adds
an override on MusicXML import based on the presence of non-symbol text.

Duplicate of musescore#8583
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@its-not-nice its-not-nice its-not-nice approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iveshenry18 @its-not-nice @vpereverzev