Fix #270709: fix MusicXML export of Jump and Marker elements with custom labels #8493
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitrio95
force-pushed
the
musicxml-export-custom-jump-labels
branch
from
376444b to
70755ad
Compare
|
@iveshenry18 wouldn't that be something for 3.6.2_backend too? |
|
cc @lvinken |
Possibly! I'll see about cherry-picking it next week. |
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 5, 2021
…tom labels Backport of musescore#8493
vpereverzev
approved these changes
Jul 5, 2021
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 6, 2021
…tom labels Backport of musescore#8493
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 13, 2021
…tom labels Backport of musescore#8493
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 27, 2021
…tom labels Backport of musescore#8493
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 27, 2021
…tom labels Backport of musescore#8493
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 27, 2021
…tom labels Backport of musescore#8493
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 27, 2021
…tom labels Backport of musescore#8493
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 27, 2021
…tom labels Backport of musescore#8493
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 27, 2021
…tom labels Backport of musescore#8493
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 28, 2021
…tom labels Backport of musescore#8493
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 28, 2021
…tom labels Backport of musescore#8493
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 13, 2021
…tom labels Backport of musescore#8493
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 13, 2021
…tom labels Backport of musescore#8493
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 19, 2021
…tom labels Backport of musescore#8493
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 19, 2021
…tom labels Backport of musescore#8493
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 30, 2021
…tom labels Backport of musescore#8493
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 1, 2021
…tom labels Backport of musescore#8493
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 2, 2021
…tom labels Backport of musescore#8493
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 10, 2021
…tom labels Backport of musescore#8493
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 23, 2021
…tom labels Backport of musescore#8493
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Mar 5, 2023
…tom labels Backport of musescore#8493
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://musescore.org/en/node/270709
This pull request allows MusicXML export of Jump and Marker elements (Segno, To Coda etc.) with custom jump labels, except for the case when one "To Coda" marker should eventually jump to two different places (see also my comment in the issue). Jump labels in the exported MusicXML file now correspond to labels assigned to the respective Coda elements, which is why one test reference file got changed.
Since marker types with custom labels do not get saved to MSCX files (which is partially described in this issue, in the part concerning "To Coda" marker having changed to "Custom" type), MusicXML exporter has to guess a marker type from the actual usage of the marker's jump label. This logic is also implemented in this pull request so Marker elements with custom labels don't get ignored (if their type can be deduced).