[MU3 Backend] ENG-9: Limit copyright info to first page #8447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iveshenry18
force-pushed
the
ENG-9-copyright-info
branch
from
58779f5 to
d09fa12
Compare
iveshenry18
force-pushed
the
ENG-9-copyright-info
branch
3 times, most recently
from
1546b35 to
e848b23
Compare
its-not-nice
approved these changes
Jul 20, 2021
iveshenry18
force-pushed
the
ENG-9-copyright-info
branch
from
e848b23 to
19e06c7
Compare
iveshenry18
force-pushed
the
ENG-9-copyright-info
branch
from
19e06c7 to
15df67c
Compare
Currently, MuseScore displays copyright metadata in a centered footer. This results in the information being displayed on every page, which is inconsistent with many published scores. This commit hides the footers on import and rather creates a VBox, populates it with the copyright metadata, and places it at the bottom of the first page (either below the first explicit pagebreak, or below the last system of the first page after an initial layout).
iveshenry18
force-pushed
the
ENG-9-copyright-info
branch
from
15df67c to
8a9eaac
Compare
8 tasks
|
Changes added to #8763 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: ENG-9: Copyright info appears on every page
Currently, MuseScore displays copyright metadata in a centered footer by default.
This results in the information being displayed on every page, which
is inconsistent with many published scores.
This commit hides the footers on XML import and rather creates a VBox,
populates it with the copyright metadata, and places it at the bottom
of the first page (either below the first explicit pagebreak, or below
the last system of the first page after an initial layout).